build(4.x) OpenEXR 2.2 or earlier cannot be used with C++17 or later by Kumataro · Pull Request #26678 · opencv/opencv

Kumataro · 2024-12-29T02:25:38Z

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

I agree to contribute to the project under Apache 2 License.
To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
The PR is proposed to the proper branch
There is a reference to the original bug report and related work
There is accuracy test, performance test and test data in opencv_extra repository, if applicable
Patch to opencv_extra has the same branch name.
The feature is well documented and sample code can be built with the project CMake

…17 or later.

opencv-alalek · 2024-12-29T02:35:12Z

cmake/OpenCVFindOpenEXR.cmake

  if(NOT OPENEXR_VERSION)
    SET(OPENEXR_VERSION "Unknown")
+  else()
+    if(HAVE_CXX17 AND OPENEXR_VERSION STRLESS "2_3")


STRLESS
"2_3"

Why is not VERSION_LESS?

OPENEXR_VERSION=2.3.0

Thank you for your comment!

I think usually ‘VERSION_LESS` is better to compare version strings, but OpenCV use not standard version string for system OpenEXR, which is splited with "_" instead of ".".

Like built-in OpenEXR. I'll try to fix this at this pull request.

opencv/cmake/OpenCVFindOpenEXR.cmake

Lines 100 to 102 in 1b48eaf

IF (OPENEXR_VERSION_MAJOR AND OPENEXR_VERSION_MINOR)

set(OPENEXR_VERSION "${OPENEXR_VERSION_MAJOR}_${OPENEXR_VERSION_MINOR}")

ENDIF ()

https://cmake.org/cmake/help/latest/command/if.html#version-comparisons

if(<variable|string> VERSION_LESS <variable|string>)
Component-wise integer version number comparison (version format is major[.minor[.patch[.tweak]]], omitted components are treated as zero).

Build-in OpenEXR (Ver 2.3.0)

-- PNG: /usr/lib/x86_64-linux-gnu/libpng.so (ver 1.6.43) -- TIFF: /usr/lib/x86_64-linux-gnu/libtiff.so (ver 42 / 4.5.1) -- JPEG 2000: OpenJPEG (ver 2.5.0) -- OpenEXR: build (ver 2.3.0)

System OpenEXR (Ver 2_2)

-- PNG: /usr/lib/x86_64-linux-gnu/libpng.so (ver 1.6.43) -- TIFF: /usr/lib/x86_64-linux-gnu/libtiff.so (ver 42 / 4.5.1) -- JPEG 2000: OpenJPEG (ver 2.5.0) -- OpenEXR: /usr/local/lib/libImath-2_2.so /usr/local/lib/libIlmImf-2_2.so /usr/local/lib/libIex-2_2.so /usr/local/lib/libHalf.so /usr/local/lib/libIlmThread-2_2.so (ver 2_2)

I fixed it. Currently OPENEXR_VERSION had been also used to search libraries.
So I split it into OPENEXR_VERSION_MM to search and OPENEXR_VERSION to show and comparing.

-- PNG: /usr/lib/x86_64-linux-gnu/libpng.so (ver 1.6.43) -- TIFF: /usr/lib/x86_64-linux-gnu/libtiff.so (ver 42 / 4.5.1) -- JPEG 2000: OpenJPEG (ver 2.5.0) -- OpenEXR: /usr/local/lib/libImath-2_2.so /usr/local/lib/libIlmImf-2_2.so /usr/local/lib/libIex-2_2.so /usr/local/lib/libHalf.so /usr/local/lib/libIlmThread-2_2.so (ver 2.2.0)

And I also fixed potential problem.

IF (OPENEXR_VERSION_MAJOR AND OPENEXR_VERSION_MINOR) set(OPENEXR_VERSION "${OPENEXR_VERSION_MAJOR}_${OPENEXR_VERSION_MINOR}") ENDIF ()

If OpenEXR Ver x.0.y is used, this set(OPENEXR_VERSION) statement will not be executed.

IF (OPENEXR_VERSION_MAJOR AND OPENEXR_VERSION_MINOR) IF (4 AND 0) IF (TRUE AND FALSE) # non-zero means TRUE, zero means FALSE IF (FALSE)

cmake/OpenCVFindOpenEXR.cmake

Kumataro · 2024-12-29T22:42:19Z

Test in PR:4.x / macOS-ARM64-Vulkan / BuildAndTest is failed, but this test is failed in other pull quest too(from about 12/22 ?) . So I believe they are not related.

[ RUN      ] Test_TFLite.face_landmark/0, where GetParam() = VKCOM/VULKAN
/Users/opencv-cn/GHA-OCV-3/_work/opencv/opencv/opencv/modules/dnn/test/test_common.impl.hpp:84: Failure
Expected: (normL1) <= (l1), actual: 2.13794e-05 vs 2e-05
conv2d_20  |ref| = 164.86170959472656
[  FAILED  ] Test_TFLite.face_landmark/0, where GetParam() = VKCOM/VULKAN (31 ms)

opencv/modules/dnn/test/test_common.impl.hpp

Lines 79 to 88 in 9c33bae

    
           void normAssert( 
        
                   cv::InputArray ref, cv::InputArray test, const char *comment /*= ""*/, 
        
                   double l1 /*= 0.00001*/, double lInf /*= 0.0001*/) 
        
           { 
        
               double normL1 = cvtest::norm(ref, test, cv::NORM_L1) / ref.getMat().total(); 
        
               EXPECT_LE(normL1, l1) << comment << "  |ref| = " << cvtest::norm(ref, cv::NORM_INF); 
        
               double normInf = cvtest::norm(ref, test, cv::NORM_INF); 
        
               EXPECT_LE(normInf, lInf) << comment << "  |ref| = " << cvtest::norm(ref, cv::NORM_INF); 
        
           }

asmorkalov · 2024-12-31T07:27:07Z

Vulkan issue addressed in #26691.

asmorkalov · 2025-01-23T12:33:07Z

@Kumataro please rebase the PR and fix the conflicts. Is the PR ready for integration?

…17 or later.

Kumataro · 2025-01-23T13:52:17Z

Umm ... I feel there are something wrongs.
I'm not familiar to git rebase. git log shows my expected result.
However it seems that this pull request contains 108 commit ...?

Should I recreate new pull request and/or branch again ?

commit 8bd3127e88ff49f2eefdbbb4db4bc6c35eea8c46 (HEAD -> fix26673, priv/fix26673)
Merge: 5e07bf7af6 3ac42c0102
Author: Kumataro <Kumataro@users.noreply.github.com>
Date:   Thu Jan 23 22:35:28 2025 +0900

    fix to conflict

commit 5e07bf7af67190c56030043b5452d1fd1871fb15
Author: Kumataro <Kumataro@users.noreply.github.com>
Date:   Thu Jan 23 22:30:48 2025 +0900

    fix to conflict

commit a6c22dc49591cdc1018082cd30b047c914000360
Author: Kumataro <Kumataro@users.noreply.github.com>
Date:   Sun Dec 29 19:03:15 2024 +0900

    replace tab to space

commit 909c3ea55632f2fa86f7b76d40c869b853edfceb
Author: Kumataro <Kumataro@users.noreply.github.com>
Date:   Sun Dec 29 12:37:55 2024 +0900

    change version string format

commit 2c820757a1c813931db40f34cc5e973c7e09783f
Author: Kumataro <Kumataro@users.noreply.github.com>
Date:   Sun Dec 29 11:01:28 2024 +0900

    imgcodecs: OpenEXR 2.2 or earlier cannot be used combination with C++17 or later.

commit 4a4031dc48475ec3354d28a3cdedda57a8913443 (origin/master, origin/HEAD, origin/4.x, 4.x)
Merge: c623a5afc1 f825b4d1ab
Author: Alexander Smorkalov <2536374+asmorkalov@users.noreply.github.com>
Date:   Wed Jan 22 20:48:29 2025 +0300

    Merge pull request #26601 from dai-xin:4.x

    VideoCapture open camera slow

sturkmen72 · 2025-01-23T14:00:39Z

i think you should click edit and select target branch

Kumataro · 2025-01-23T14:05:08Z

Thank you very much for your advice !! I fixed it now.

fengyuentau

Thank you!

OpenEXR 2.2 or earlier cannot be used with C++17 or later opencv#26678 Close opencv#26673 Close opencv#25313 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake

imgcodecs: OpenEXR 2.2 or earlier cannot be used combination with C++…

85bd5b4

…17 or later.

opencv-alalek reviewed Dec 29, 2024

View reviewed changes

fengyuentau reviewed Dec 29, 2024

View reviewed changes

cmake/OpenCVFindOpenEXR.cmake Show resolved Hide resolved

change version string format

906d40e

asmorkalov added category: build/install category: 3rdparty labels Dec 29, 2024

opencv-alalek reviewed Dec 29, 2024

View reviewed changes

cmake/OpenCVFindOpenEXR.cmake Show resolved Hide resolved

replace tab to space

3ac42c0

Kumataro mentioned this pull request Jan 3, 2025

imgcodecs: (5.x) drop bundled OpenEXR #26708

Merged

6 tasks

asmorkalov added this to the 4.12.0 milestone Jan 4, 2025

Kumataro added 5 commits January 23, 2025 22:33

imgcodecs: OpenEXR 2.2 or earlier cannot be used combination with C++…

2c82075

…17 or later.

change version string format

909c3ea

replace tab to space

a6c22dc

fix to conflict

5e07bf7

fix to conflict

8bd3127

fengyuentau approved these changes Jan 24, 2025

View reviewed changes

asmorkalov assigned fengyuentau Jan 24, 2025

asmorkalov merged commit ab77e1c into opencv:4.x Jan 24, 2025

asmorkalov mentioned this pull request Feb 19, 2025

5.x merge 4.x #26939

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

build(4.x) OpenEXR 2.2 or earlier cannot be used with C++17 or later#26678

build(4.x) OpenEXR 2.2 or earlier cannot be used with C++17 or later#26678
asmorkalov merged 8 commits intoopencv:4.xfrom
Kumataro:fix26673

Kumataro commented Dec 29, 2024 •

edited

Loading

Uh oh!

opencv-alalek Dec 29, 2024

Uh oh!

Kumataro Dec 29, 2024

Uh oh!

Kumataro Dec 29, 2024

Uh oh!

Uh oh!

Uh oh!

Kumataro commented Dec 29, 2024

Uh oh!

asmorkalov commented Dec 31, 2024

Uh oh!

asmorkalov commented Jan 23, 2025

Uh oh!

Kumataro commented Jan 23, 2025

Uh oh!

sturkmen72 commented Jan 23, 2025

Uh oh!

Kumataro commented Jan 23, 2025

Uh oh!

fengyuentau left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	IF (OPENEXR_VERSION_MAJOR AND OPENEXR_VERSION_MINOR)
	set(OPENEXR_VERSION "${OPENEXR_VERSION_MAJOR}_${OPENEXR_VERSION_MINOR}")
	ENDIF ()

Uh oh!

Conversation

Kumataro commented Dec 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Readiness Checklist

Uh oh!

opencv-alalek Dec 29, 2024

Choose a reason for hiding this comment

Uh oh!

Kumataro Dec 29, 2024

Choose a reason for hiding this comment

Uh oh!

Kumataro Dec 29, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Kumataro commented Dec 29, 2024

Uh oh!

asmorkalov commented Dec 31, 2024

Uh oh!

asmorkalov commented Jan 23, 2025

Uh oh!

Kumataro commented Jan 23, 2025

Uh oh!

sturkmen72 commented Jan 23, 2025

Uh oh!

Kumataro commented Jan 23, 2025

Uh oh!

fengyuentau left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Kumataro commented Dec 29, 2024 •

edited

Loading