Skip to content

Android camera refactoring#26646

Merged
asmorkalov merged 6 commits intoopencv:4.xfrom
warped-rudi:refactoring
Jan 22, 2025
Merged

Android camera refactoring#26646
asmorkalov merged 6 commits intoopencv:4.xfrom
warped-rudi:refactoring

Conversation

@warped-rudi
Copy link
Copy Markdown
Contributor

This patch set does not contain any functional changes. It just cleans up the code structure to improve readability and to prepare for future changes.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@warped-rudi
Copy link
Copy Markdown
Contributor Author

@asmorkalov Can we merge this earlier? I have another (most likely final) change set for the camera stuff here that relies on this pull request.

@asmorkalov asmorkalov self-requested a review January 10, 2025 11:54
@asmorkalov asmorkalov self-assigned this Jan 10, 2025
Using shared pointers for unshared data is considered an antipattern.
Don't leak internal functions into global namespace. Some member
variables are now private as well.
Also make internally used member functions private.
Also remove some unneccessary initialisations from initCapture().
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually.

@asmorkalov asmorkalov merged commit c623a5a into opencv:4.x Jan 22, 2025
@warped-rudi warped-rudi deleted the refactoring branch January 23, 2025 06:50
@asmorkalov asmorkalov mentioned this pull request Feb 19, 2025
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
Android camera refactoring opencv#26646

This patch set does not contain any functional changes. It just cleans up the code structure to improve readability and to prepare for future changes.

* videoio(Android): Use 'unique_ptr' instead of 'shared_ptr'
Using shared pointers for unshared data is considered an antipattern.
* videoio(Android): Make callback functions private static members
Don't leak internal functions into global namespace. Some member
variables are now private as well.
* videoio(Android): Move resolution matching into separate function
Also make internally used member functions private.
* videoio(Android): Move ranges query into separate function
Also remove some unneccessary initialisations from initCapture().
* videoio(Android): Wrap extremly long source code lines
* videoio(Android): Rename members of 'RangeValue'

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants