Skip to content

js: fix generation of "const const" in code#26640

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
vrabaud:opencv_js3
Dec 19, 2024
Merged

js: fix generation of "const const" in code#26640
asmorkalov merged 2 commits intoopencv:4.xfrom
vrabaud:opencv_js3

Conversation

@vrabaud
Copy link
Copy Markdown
Contributor

@vrabaud vrabaud commented Dec 18, 2024 •
edited by asmorkalov
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Docs=docs-js
Xbuild_image:Custom=javascript
Xbuild_image:Custom=javascript-simd
Xbuild_image:Custom=javascript-simd:3.1.64
build_image:Custom=javascript:3.1.64
buildworker:Custom=linux-4

@vrabaud vrabaud requested a review from asmorkalov December 18, 2024 10:52
@vrabaud vrabaud mentioned this pull request Dec 18, 2024
Merged
4 tasks
@asmorkalov asmorkalov self-assigned this Dec 18, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 18, 2024

The PR changes behaviour. I see the following test failure:

Errors:

Module: Features2D Test: Drawing
Died on test #2: 51030296
    at global.test.QUnit.test (/mnt/Projects/Projects/opencv-build-js/js/bin/node_modules/node-qunit/lib/child.js:132:17)
    at Object.<anonymous> (/mnt/Projects/Projects/opencv-build-js/js/bin/test_features2d.js:88:7)
    at Module._compile (node:internal/modules/cjs/loader:1469:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1548:10)
    at Module.load (node:internal/modules/cjs/loader:1288:32)
    at Module._load (node:internal/modules/cjs/loader:1104:12)
    at Module.require (node:internal/modules/cjs/loader:1311:19)
    at /mnt/Projects/Projects/opencv-build-js/js/bin/node_modules/qunit/qunit/qunit.js:2944:16

@asmorkalov asmorkalov mentioned this pull request Dec 18, 2024
Merged
6 tasks
@vrabaud
Copy link
Copy Markdown
Contributor Author

vrabaud commented Dec 18, 2024

Indeed, i just fixed InputOutputArray, it works for me.

asmorkalov
asmorkalov approved these changes Dec 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually.

@asmorkalov asmorkalov merged commit 79d019b into opencv:4.x Dec 19, 2024
@vrabaud vrabaud deleted the opencv_js3 branch December 19, 2024 13:33
@dkurt dkurt added this to the 4.11.0 milestone Dec 26, 2024
@asmorkalov asmorkalov mentioned this pull request Jan 15, 2025
Merged
shyama7004 pushed a commit to shyama7004/opencv that referenced this pull request Jan 20, 2025
@vrabaud @shyama7004
Merge pull request opencv#26640 from vrabaud:opencv_js3
7bd4401 
js: fix generation of "const const" in code opencv#26640

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
@vrabaud @NanQin555
Merge pull request opencv#26640 from vrabaud:opencv_js3
a1cfed0 
js: fix generation of "const const" in code opencv#26640

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: javascript (js)

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vrabaud @asmorkalov @dkurt