Skip to content

Emscripten build fixes#26537

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
artoolkitx:emscripten-build-fixes
Nov 28, 2024
Merged

Emscripten build fixes#26537
asmorkalov merged 2 commits intoopencv:4.xfrom
artoolkitx:emscripten-build-fixes

Conversation

@philip-lamb
Copy link
Copy Markdown
Contributor

@philip-lamb philip-lamb commented Nov 27, 2024

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Docs=docs-js
Xbuild_image:Custom=javascript
Xbuild_image:Custom=javascript-simd
Xbuild_image:Custom=javascript-simd:3.1.64
build_image:Custom=javascript:3.1.64
buildworker:Custom=linux-4

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks a lot for the contribution! Tested manually with Emsdk latest.

@asmorkalov asmorkalov merged commit a5f8711 into opencv:4.x Nov 28, 2024
@asmorkalov asmorkalov mentioned this pull request Nov 28, 2024
@philip-lamb philip-lamb deleted the emscripten-build-fixes branch November 28, 2024 22:09
@asmorkalov asmorkalov mentioned this pull request Jan 15, 2025
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
Emscripten build fixes opencv#26537

- Corrects typo in Emscripten-only intrinsics header (Fixes opencv#26536)
- Updates deprecated intrinsic title (as per LLVM final intrinsic name).

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build of OpenCV 4.10.0 with Emscripten fails if simd options enabled

3 participants