Skip to content

Add *_WIDE flags to cv::seamlessClone#26511

Merged
asmorkalov merged 4 commits intoopencv:4.xfrom
sturkmen72:proposed_fix_for_21902
Dec 19, 2024
Merged

Add *_WIDE flags to cv::seamlessClone#26511
asmorkalov merged 4 commits intoopencv:4.xfrom
sturkmen72:proposed_fix_for_21902

Conversation

@sturkmen72
Copy link
Copy Markdown
Contributor

@sturkmen72 sturkmen72 commented Nov 24, 2024

suggested fix for #25947 #21902 #15928 RFC

personally i don't believe changes about shifting are not really needed. but i prepared this PR to be helpful on discussions about related issue.
i will add more information on the issue.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@sturkmen72 sturkmen72 force-pushed the proposed_fix_for_21902 branch from a6356f4 to eb007ac Compare December 1, 2024 23:27
@sturkmen72 sturkmen72 force-pushed the proposed_fix_for_21902 branch from 7ed804c to 36f08dd Compare December 10, 2024 19:03
@asmorkalov asmorkalov self-assigned this Dec 18, 2024
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I just propose to tune naming.

@asmorkalov asmorkalov changed the title [WIP] Add *_ALT flags to cv::seamlessClone Add *_ALT flags to cv::seamlessClone Dec 18, 2024
@asmorkalov asmorkalov changed the title Add *_ALT flags to cv::seamlessClone Add *_WIDE flags to cv::seamlessClone Dec 18, 2024
@asmorkalov asmorkalov merged commit 60d35d1 into opencv:4.x Dec 19, 2024
@sturkmen72 sturkmen72 deleted the proposed_fix_for_21902 branch December 19, 2024 13:09
@asmorkalov asmorkalov mentioned this pull request Jan 15, 2025
shyama7004 pushed a commit to shyama7004/opencv that referenced this pull request Jan 20, 2025
* add alternative flags to cv::seamlessClone

* Update photo.hpp

* Update seamless_cloning.cpp

* Update seamless_cloning_impl.cpp
NanQin555 pushed a commit to NanQin555/opencv that referenced this pull request Feb 24, 2025
* add alternative flags to cv::seamlessClone

* Update photo.hpp

* Update seamless_cloning.cpp

* Update seamless_cloning_impl.cpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants