Skip to content

Remove internal calib3d_c_api.h#26461

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
vrabaud:4x_calibration_base
Nov 19, 2024
Merged

Remove internal calib3d_c_api.h#26461
asmorkalov merged 1 commit intoopencv:4.xfrom
vrabaud:4x_calibration_base

Conversation

@vrabaud
Copy link
Copy Markdown
Contributor

@vrabaud vrabaud commented Nov 14, 2024 •
edited
Loading

The new C++ code is copy/pasted from OpenCV5:

  • functions initIntrinsicParams2D, subMatrix (the first 160 lines)
  • function prepareDistCoeffs
  • the different asserts

Not all the API/code is ported to C++ yet to ease the review.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@vrabaud vrabaud added the cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) label Nov 14, 2024
@vrabaud vrabaud marked this pull request as ready for review November 14, 2024 14:16
@vrabaud vrabaud requested a review from asmorkalov November 14, 2024 14:17
@asmorkalov asmorkalov self-assigned this Nov 14, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Nov 14, 2024
@vrabaud vrabaud force-pushed the 4x_calibration_base branch from 7e30889 to 763eb31 Compare November 14, 2024 22:06
@vrabaud
Copy link
Copy Markdown
Contributor Author

vrabaud commented Nov 14, 2024

There is a small bug fix I need to bring to 5.x before mergng this, please hold.

@vrabaud
Remove internal calib3d_c_api.h
8c6339c 
The new C++ code is copy/pasted from OpenCV5:
- functions initIntrinsicParams2D, subMatrix (the first 160 lines)
- function prepareDistCoeffs
- the different asserts

Not all the API/code is ported to C++ yet to ease the review.
@vrabaud vrabaud force-pushed the 4x_calibration_base branch from 763eb31 to 8c6339c Compare November 15, 2024 08:31
@vrabaud
Copy link
Copy Markdown
Contributor Author

vrabaud commented Nov 15, 2024

I propose my small 5.x fixes in #26466

@asmorkalov asmorkalov merged commit 64273c8 into opencv:4.x Nov 19, 2024
@asmorkalov asmorkalov mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: calib3d cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@vrabaud @asmorkalov