Skip to content

Fix minor bugs in calibration.#26466

Merged
asmorkalov merged 1 commit intoopencv:5.xfrom
vrabaud:5.x_calibration_fix
Nov 18, 2024
Merged

Fix minor bugs in calibration.#26466
asmorkalov merged 1 commit intoopencv:5.xfrom
vrabaud:5.x_calibration_fix

Conversation

@vrabaud
Copy link
Copy Markdown
Contributor

@vrabaud vrabaud commented Nov 15, 2024

These were discovered when porting 4.x to C++

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

- the asserts are contradictory with the asserts below
- fix when rvecs/tvecs are requested
@asmorkalov asmorkalov self-assigned this Nov 18, 2024
@asmorkalov asmorkalov merged commit 0d7d045 into opencv:5.x Nov 18, 2024
@vrabaud vrabaud deleted the 5.x_calibration_fix branch November 18, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants