Skip to content

Empty Mat in FileStorage#26446

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
dkurt:file_storage_empty_and_1d_mat
Nov 12, 2024
Merged

Empty Mat in FileStorage#26446
asmorkalov merged 2 commits intoopencv:4.xfrom
dkurt:file_storage_empty_and_1d_mat

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Nov 11, 2024 •
edited
Loading

Pull Request Readiness Checklist

port #26420 + #26444

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@dkurt dkurt changed the title Change style of empty and 1d Mat in FileStorage Empty and 1d Mat in FileStorage Nov 12, 2024
@dkurt dkurt marked this pull request as ready for review November 12, 2024 05:11
asmorkalov
asmorkalov reviewed Nov 12, 2024
View reviewed changes
@dkurt dkurt changed the title Empty and 1d Mat in FileStorage Empty Mat in FileStorage Nov 12, 2024
@asmorkalov asmorkalov self-assigned this Nov 12, 2024
@asmorkalov asmorkalov merged commit c230841 into opencv:4.x Nov 12, 2024
@dkurt dkurt added the port/backport done Label for maintainers. Authors of PR can ignore this label Nov 12, 2024
@asmorkalov asmorkalov mentioned this pull request Nov 13, 2024
Merged
@dkurt dkurt added this to the 4.11.0 milestone Dec 26, 2024
thewoz pushed a commit to CobbsLab/OPENCV that referenced this pull request Feb 13, 2025
@dkurt @thewoz
Merge pull request opencv#26446 from dkurt:file_storage_empty_and_1d_mat
7c6d79c 
* Change style of empty and 1d Mat in FileStorage

* Remove misleading 1d Mat test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

@asmorkalov asmorkalov

Labels

category: core feature port/backport done Label for maintainers. Authors of PR can ignore this test

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dkurt @asmorkalov