Skip to content

int64 data type support for FileStorage. 1d and empty Mat with exact dimensions#26434

Merged
asmorkalov merged 4 commits intoopencv:4.xfrom
dkurt:dk/int64_file_storage_4.x
Nov 11, 2024
Merged

int64 data type support for FileStorage. 1d and empty Mat with exact dimensions#26434
asmorkalov merged 4 commits intoopencv:4.xfrom
dkurt:dk/int64_file_storage_4.x

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Nov 8, 2024 •
edited
Loading

Pull Request Readiness Checklist

Port of #26399 to 4.x branch

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@dkurt dkurt added port/backport done Label for maintainers. Authors of PR can ignore this category: core feature labels Nov 8, 2024
@asmorkalov asmorkalov self-requested a review November 8, 2024 06:03
@asmorkalov asmorkalov added this to the 4.11.0 milestone Nov 8, 2024
@asmorkalov asmorkalov self-assigned this Nov 8, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 8, 2024 •
edited
Loading

Debug:

[ RUN      ] Core_InputOutput.filestorage_base64_basic_read_XML
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_read_XML (2 ms)
[ RUN      ] Core_InputOutput.filestorage_base64_basic_read_YAML
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_read_YAML (1 ms)
[ RUN      ] Core_InputOutput.filestorage_base64_basic_read_JSON
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_read_JSON (1 ms)
[ RUN      ] Core_InputOutput.filestorage_base64_basic_rw_XML
Storage size: 5458
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_rw_XML (1 ms)
[ RUN      ] Core_InputOutput.filestorage_base64_basic_rw_YAML
Storage size: 5283
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_rw_YAML (2 ms)
[ RUN      ] Core_InputOutput.filestorage_base64_basic_rw_JSON
Storage size: 5128
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_rw_JSON (2 ms)
[ RUN      ] Core_InputOutput.filestorage_base64_basic_memory_XML
Storage size: 5458
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_memory_XML (1 ms)
[ RUN      ] Core_InputOutput.filestorage_base64_basic_memory_YAML
Storage size: 5283
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_memory_YAML (2 ms)
[ RUN      ] Core_InputOutput.filestorage_base64_basic_memory_JSON
Storage size: 5128
unknown file: Failure
C++ exception with description "OpenCV(4.10.0-dev) /home/ci/opencv/modules/core/include/opencv2/core/mat.inl.hpp:670: error: (-215:Assertion failed) res != 0 in function 'elemSize'
" thrown in the test body.
[  FAILED  ] Core_InputOutput.filestorage_base64_basic_memory_JSON (1 ms)

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Nov 8, 2024

Test fails on fs["empty_2d_mat"] >> _em_in;

@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Nov 11, 2024

@asmorkalov, I can port empty mat separately

@dkurt dkurt force-pushed the dk/int64_file_storage_4.x branch from 3a9ede4 to 7ce5960 Compare November 11, 2024 07:30
@dkurt dkurt requested a review from asmorkalov November 11, 2024 09:03
@asmorkalov asmorkalov merged commit 37c2af6 into opencv:4.x Nov 11, 2024
@asmorkalov asmorkalov mentioned this pull request Nov 13, 2024
Merged
@ghost ghost mentioned this pull request Jan 23, 2025
Closed
thewoz pushed a commit to CobbsLab/OPENCV that referenced this pull request Feb 13, 2025
@dkurt @thewoz
Merge pull request opencv#26434 from dkurt:dk/int64_file_storage_4.x
4d2e70a 
int64 data type support for FileStorage. 1d and empty Mat with exact dimensions opencv#26434

### Pull Request Readiness Checklist

Port of opencv#26399 to 4.x branch

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: core feature port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

2 participants

@dkurt @asmorkalov