backport C++ 3d/calibration_base.cpp:5.x to calib3d/calibration_base.cpp:4.x#26414
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Nov 8, 2024
Merged
backport C++ 3d/calibration_base.cpp:5.x to calib3d/calibration_base.cpp:4.x#26414asmorkalov merged 2 commits intoopencv:4.xfrom
asmorkalov merged 2 commits intoopencv:4.xfrom
Conversation
7af9717 to
7d7c9c2
Compare
7d7c9c2 to
ecd8147
Compare
asmorkalov
reviewed
Nov 6, 2024
ecd8147 to
c77eaa3
Compare
Contributor
Author
|
I actually removed the C functions: they are only used internally and the C code that was calling them is not calling the C++ functions. |
c77eaa3 to
af6d6d3
Compare
Contributor
Author
|
I just added a little fix for vertical distortion coefficients (I thought our internal failing test was flaky). This code will be removed in a future PR anyway. |
79af869 to
5061ff3
Compare
5061ff3 to
b66d78e
Compare
asmorkalov
approved these changes
Nov 8, 2024
Merged
thewoz
pushed a commit
to CobbsLab/OPENCV
that referenced
this pull request
Feb 13, 2025
…cpp:4.x (opencv#26414) * Add vanilla calibration_base from 5.x This is from 5510571 * Have the C implementation use the new C++ one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to minimize the differences between 4.x and 5.x
To review this PR, it is best to look at the second commit which is a simpler diff.
The next steps are:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request