Replace operators with wrapper functions on universal intrinsics backends#26109
Merged
asmorkalov merged 12 commits intoopencv:4.xfrom Sep 13, 2024
Merged
Replace operators with wrapper functions on universal intrinsics backends#26109asmorkalov merged 12 commits intoopencv:4.xfrom
asmorkalov merged 12 commits intoopencv:4.xfrom
Conversation
WanliZhong
commented
Sep 4, 2024
Contributor
|
@WanliZhong, please, check it; it now does not complain on v_add & v_mul, but complains about v_exp etc. |
6 tasks
Contributor
|
@fengyuentau could you check longsoon branch? |
Contributor
|
@mshabunin @opencv-alalek could you take a look? |
Member
Author
|
@asmorkalov Longsoon tests are all passed. (GUI test failed is not related to this PR, because it's server) |
Contributor
|
cc @hanliutong |
asmorkalov
reviewed
Sep 12, 2024
Member
Author
|
The default test error about |
asmorkalov
approved these changes
Sep 13, 2024
Merged
4 tasks
thewoz
pushed a commit
to CobbsLab/OPENCV
that referenced
this pull request
Feb 13, 2025
…warpper Replace operators with wrapper functions on universal intrinsics backends opencv#26109 This PR aims to replace the operators(logic, arithmetic, bit) with wrapper functions(v_add, v_eq, v_and...) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
4 tasks
|
Why? Seriously why breaking existing code that uses the intrinsics? OpenCV is actually only sane library I found around that provides useful cross platform intrinsics. What would you remove useful C++ operators? Why breaking user code - especially for a projects that is used all around the world! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to replace the operators(logic, arithmetic, bit) with wrapper functions(v_add, v_eq, v_and...)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.