Merged
Conversation
Contributor
|
see comments in #25963 |
Contributor
Author
|
I saw the comment about the button to switch between C++ and Python so I'll implement that. I'm also new to contributing to this project so if there any other tests you think I should run for this please let me know. |
Contributor
Author
|
I could also tackle a follow on PR to actually have similar descriptions for the Python Script as the C++ but it didn't seem like that was in the scope of this particular PR. |
Contributor
Author
|
I added the toggle, but note that the explanations below it are still C++ only. From what it sounds like, a Python specific explanation is out of scope for this issue. I think it would require toggling that section plus developing a Python code explanation. |
b5a3654 to
cb72a21
Compare
asmorkalov
approved these changes
Aug 19, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.