Skip to content

Added reference to Python example (stitching.py) in the High-Level St…#25963

Closed
Suyog-16 wants to merge 2 commits intoopencv:4.xfrom
Suyog-16:add-python-example-to-stitching-tutorial-4.x
Closed

Added reference to Python example (stitching.py) in the High-Level St…#25963
Suyog-16 wants to merge 2 commits intoopencv:4.xfrom
Suyog-16:add-python-example-to-stitching-tutorial-4.x

Conversation

@Suyog-16
Copy link
Copy Markdown

@Suyog-16 Suyog-16 commented Jul 28, 2024

What this Pull Request (PR) does

Added reference to Python example (stitching.py) in the High-Level Stitching API Tutorial for 4.x.

Related issues

This PR addresses the issue where the tutorial only referenced the C++ example and did not include the Python example.

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added the category: documentation Documentation fix or update label Jul 29, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Jul 29, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 29, 2024 

Run cd /home/ci/opencv
doc/tutorials/others/stitcher.markdown:30: trailing whitespace.
+A similar script is available for Python 
Error: Process completed with exit code 2.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 30, 2024

I reviewed the tutorial and just link addition is not enough. The tutorial describes parts of code and it does not work for python as is. You need to rewrite some text pieces and use switch for python/c++ like in https://docs.opencv.org/4.x/d3/d96/tutorial_basic_geometric_drawing.html

@Suyog-16
Copy link
Copy Markdown
Author

Suyog-16 commented Jul 30, 2024

Well i took this issue thinking it would be an easy fix, but i am unknown with changing the code snippets and rewriting them . I think someone with experience could take this issue and help here .Thank you for your understanding

@Suyog-16 Suyog-16 closed this Jul 30, 2024
@asmorkalov asmorkalov mentioned this pull request Aug 2, 2024
Merged
5 tasks
@ericmariasis
Copy link
Copy Markdown
Contributor

ericmariasis commented Aug 2, 2024

Let me try to tackle the switch as part of PR 25962.

@ericmariasis
Copy link
Copy Markdown
Contributor

ericmariasis commented Aug 2, 2024 •
edited
Loading

I added the toggle in PR 25962, but note that the explanations below it are still C++ only. From what it sounds like, a Python specific explanation is out of scope for this issue.

@Suyog-16 Suyog-16 deleted the add-python-example-to-stitching-tutorial-4.x branch August 18, 2024 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

category: documentation Documentation fix or update incomplete

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Suyog-16 @asmorkalov @ericmariasis