Skip to content

cuda: prevent CMAKE_CUDA_ARCHITECTURES default from overiding OpenCV architecture search (issue 25920)#25941

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
cudawarped:cuda_fix_default_cuda_arch_with_cmp0104
Jul 24, 2024
Merged

cuda: prevent CMAKE_CUDA_ARCHITECTURES default from overiding OpenCV architecture search (issue 25920)#25941
asmorkalov merged 1 commit intoopencv:4.xfrom
cudawarped:cuda_fix_default_cuda_arch_with_cmp0104

Conversation

@cudawarped
Copy link
Copy Markdown
Contributor

@cudawarped cudawarped commented Jul 22, 2024 •
edited
Loading

Fix #25920 by only respecting CMAKE_CUDA_ARCHITECTURES when it is specified by the user.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@cudawarped cudawarped mentioned this pull request Jul 22, 2024
Closed
4 tasks
@asmorkalov asmorkalov self-requested a review July 23, 2024 09:39
@asmorkalov asmorkalov self-assigned this Jul 23, 2024
@asmorkalov asmorkalov added this to the 4.11.0 milestone Jul 23, 2024
@opencv-alalek opencv-alalek added the category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib label Jul 23, 2024
@asmorkalov asmorkalov merged commit 14f9d71 into opencv:4.x Jul 24, 2024
@asmorkalov asmorkalov mentioned this pull request Jul 25, 2024
Merged
This was referenced Mar 16, 2025
Closed
Closed
cudawarped added a commit to cudawarped/opencv that referenced this pull request Mar 27, 2025
@cudawarped
Add comment for CMake 3.18+: if CMAKE_CUDA_ARCHITECTURES is empty ena…
3d5ab56 
…ble_language(CUDA) sets it to the default architecture chosen by the compiler, to trigger the OpenCV custom CUDA architecture search an empty value needs to be respected see opencv#25941.
@cudawarped cudawarped mentioned this pull request Mar 27, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: build/install category: gpu/cuda (contrib) OpenCV 4.0+: moved to opencv_contrib

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

🐛 Incompatibility of CUDA CMake options

3 participants

@cudawarped @asmorkalov @opencv-alalek