Skip to content

handling I32/I64 data types in G-API ONNX back-end#25817

Merged
asmorkalov merged 16 commits intoopencv:4.xfrom
lamiayous:ly/extend_onnxrt_gapi_backend_handle_i32_i64_type
Jul 12, 2024
Merged

handling I32/I64 data types in G-API ONNX back-end#25817
asmorkalov merged 16 commits intoopencv:4.xfrom
lamiayous:ly/extend_onnxrt_gapi_backend_handle_i32_i64_type

Conversation

@lamiayous
Copy link
Copy Markdown
Contributor

@lamiayous lamiayous commented Jun 26, 2024 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@lamiayous lamiayous marked this pull request as draft June 26, 2024 17:51
@asmorkalov asmorkalov changed the title handling CV_32S handling CV_32S in G-API ONNX back-end Jun 27, 2024
TolyaTalamanov
TolyaTalamanov reviewed Jun 27, 2024
View reviewed changes
@TolyaTalamanov TolyaTalamanov self-requested a review June 27, 2024 09:39
@TolyaTalamanov TolyaTalamanov self-assigned this Jun 27, 2024
TolyaTalamanov
TolyaTalamanov reviewed Jun 27, 2024
View reviewed changes
@TolyaTalamanov TolyaTalamanov marked this pull request as ready for review June 27, 2024 11:54
@lamiayous lamiayous changed the title handling CV_32S in G-API ONNX back-end handling I32/I64 data types in G-API ONNX back-end Jun 27, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 1, 2024

@TolyaTalamanov please take a look again.

TolyaTalamanov
TolyaTalamanov reviewed Jul 1, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lamiayous let me know when it's ready for review

@lamiayous
Copy link
Copy Markdown
Contributor Author

lamiayous commented Jul 1, 2024

@TolyaTalamanov Should be ready for review

TolyaTalamanov
TolyaTalamanov reviewed Jul 1, 2024
View reviewed changes
@asmorkalov asmorkalov added this to the 4.11.0 milestone Jul 1, 2024
TolyaTalamanov
TolyaTalamanov reviewed Jul 5, 2024
View reviewed changes
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 9, 2024 


Run cd /home/ci/opencv
modules/gapi/src/backends/onnx/gonnxbackend.cpp:474: trailing whitespace.
+            
modules/gapi/src/backends/onnx/gonnxbackend.cpp:492: trailing whitespace.
+                    std::cout << std::endl; 
modules/gapi/src/backends/onnx/gonnxbackend.cpp:509: trailing whitespace.
+                    std::cout << std::endl; 
modules/gapi/src/backends/onnx/gonnxbackend.cpp:530: trailing whitespace.
+                    std::cout << std::endl; 
modules/gapi/src/backends/onnx/gonnxbackend.cpp:534: trailing whitespace.
+            return empty_tensor; 
Error: Process completed with exit code 2.

TolyaTalamanov
TolyaTalamanov reviewed Jul 11, 2024
View reviewed changes
TolyaTalamanov
TolyaTalamanov reviewed Jul 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

Only cosmetic fixes are required

TolyaTalamanov
TolyaTalamanov approved these changes Jul 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

TolyaTalamanov commented Jul 12, 2024

@asmorkalov can you merge it, please?

@asmorkalov asmorkalov merged commit 78195bc into opencv:4.x Jul 12, 2024
@asmorkalov asmorkalov mentioned this pull request Jul 16, 2024
Merged
fengyuentau pushed a commit to fengyuentau/opencv that referenced this pull request Aug 15, 2024
@lamiayous @fengyuentau
Merge pull request opencv#25817 from lamiayous:ly/extend_onnxrt_gapi_…
477758e 
…backend_handle_i32_i64_type

Handling I32/I64 data types in G-API ONNX back-end opencv#25817

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [ ] I agree to contribute to the project under Apache 2 License.
- [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TolyaTalamanov TolyaTalamanov TolyaTalamanov approved these changes

Assignees

@TolyaTalamanov TolyaTalamanov

Labels

category: g-api / gapi feature

Projects

None yet

Milestone

4.11.0

Development

Successfully merging this pull request may close these issues.

3 participants

@lamiayous @asmorkalov @TolyaTalamanov