Remove unnecessary FIXIT section in grfmt_tiff.cpp#25447
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Apr 19, 2024
Merged
Remove unnecessary FIXIT section in grfmt_tiff.cpp#25447asmorkalov merged 2 commits intoopencv:4.xfrom
asmorkalov merged 2 commits intoopencv:4.xfrom
Conversation
No int64/uint64 is used inthe code anymore. grfmt_tiff.hpp includes the tiff.h header inside of the tiff_dummy_namespace declaration. One implication of this is that all namespaced declarations made in tiff.h become qualified with tiff_dummy_namespace::. Because tiff.h includes standard library headers, the std namespace declarations are converted to tiff_dummy_namespace::std declarations. Subsequently, grfmt_tiff.hpp declares using namespace tiff_dummy_namespace;. This can lead to an ambiguity error during the resolution of the std namespace.
Contributor
Author
|
Fixes were already made in #25096 |
Contributor
Author
|
Actually, this is still problematic. Using pure C++ types is the way to go. There are only conflicts with int64 usually (defined as |
asmorkalov
approved these changes
Apr 19, 2024
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
Tested manually with Ubuntu 16.04, 18.04.
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
Remove unnecessary FIXIT section in grfmt_tiff.cpp opencv#25447 No int64/uint64 is used in the code anymore. grfmt_tiff.hpp includes the tiff.h header inside of the tiff_dummy_namespace declaration. One implication of this is that all namespaced declarations made in tiff.h become qualified with tiff_dummy_namespace::. Because tiff.h includes standard library headers, the std namespace declarations are converted to tiff_dummy_namespace::std declarations. Subsequently, grfmt_tiff.hpp declares using namespace tiff_dummy_namespace;. This can lead to an ambiguity error during the resolution of the std namespace. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No int64/uint64 is used in the code anymore.
grfmt_tiff.hpp includes the tiff.h header inside of the tiff_dummy_namespace declaration. One implication of this is that all namespaced declarations made in tiff.h become qualified with tiff_dummy_namespace::.
Because tiff.h includes standard library headers, the std namespace declarations are converted to tiff_dummy_namespace::std declarations.
Subsequently, grfmt_tiff.hpp declares using namespace tiff_dummy_namespace;.
This can lead to an ambiguity error during the resolution of the std namespace.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request