Skip to content

Added HAL function for popular bit-exact branch of GaussianBlur with sigma=0#25397

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/HAL_GaussianBlur_bit_exact
Apr 17, 2024
Merged

Added HAL function for popular bit-exact branch of GaussianBlur with sigma=0#25397
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/HAL_GaussianBlur_bit_exact

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Apr 11, 2024 •
edited
Loading

Tries to address #24850
Previous trial: #25334

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone Apr 11, 2024
@asmorkalov asmorkalov changed the title WIP: Added HAL function for popular bit-exact branch of GaussianBlur with sigma=0 Added HAL function for popular bit-exact branch of GaussianBlur with sigma=0 Apr 11, 2024
@asmorkalov asmorkalov force-pushed the as/HAL_GaussianBlur_bit_exact branch from 46cc2cb to dad7c3b Compare April 11, 2024 12:24
@asmorkalov asmorkalov requested a review from vpisarev April 11, 2024 12:25
opencv-alalek
opencv-alalek reviewed Apr 11, 2024
View reviewed changes
vpisarev
vpisarev reviewed Apr 12, 2024
View reviewed changes
asmorkalov
asmorkalov commented Apr 12, 2024
View reviewed changes
@asmorkalov asmorkalov force-pushed the as/HAL_GaussianBlur_bit_exact branch from dad7c3b to 9d962e5 Compare April 16, 2024 09:01
vpisarev
vpisarev reviewed Apr 16, 2024
View reviewed changes
@asmorkalov asmorkalov force-pushed the as/HAL_GaussianBlur_bit_exact branch from 9d962e5 to 30d525b Compare April 17, 2024 07:08
@asmorkalov asmorkalov force-pushed the as/HAL_GaussianBlur_bit_exact branch from 30d525b to f643964 Compare April 17, 2024 07:13
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Apr 17, 2024

@opencv-alalek @vpisarev I fixed remarks:

  • Moved CALL_HAL after OpenCL.
  • Renamed the function after vpisarev recommendation.
  • Added margins as in classic GaussianBlur.
  • presumed size_t and other types as in other HAL functions for consistency.

@vpisarev vpisarev self-requested a review April 17, 2024 11:23
@asmorkalov asmorkalov merged commit 05a54b1 into opencv:4.x Apr 17, 2024
@asmorkalov asmorkalov mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek left review comments

@vpisarev vpisarev vpisarev approved these changes

Assignees

@vpisarev vpisarev

Labels

category: imgproc optimization

Projects

OpenCV 4.x HAL improvement
Status: Done

Milestone

4.10.0

Development

Successfully merging this pull request may close these issues.

3 participants

@asmorkalov @vpisarev @opencv-alalek