Raise priority of HAL implementation for GaussianBlur#25334
Closed
asmorkalov wants to merge 1 commit intoopencv:4.xfrom
Closed
Raise priority of HAL implementation for GaussianBlur#25334asmorkalov wants to merge 1 commit intoopencv:4.xfrom
asmorkalov wants to merge 1 commit intoopencv:4.xfrom
Conversation
587cb09 to
7612e17
Compare
Contributor
opencv-alalek
left a comment
There was a problem hiding this comment.
@vpisarev "Transparent API" with non-transparent conditions needs your comments.
|
|
||
| static bool param_check_gaussian_blur_bitexact_kernels = utils::getConfigurationParameterBool("OPENCV_GAUSSIANBLUR_CHECK_BITEXACT_KERNELS", false); | ||
|
|
||
| if (!(useOpenCL && OpenCL_applicable) || !param_check_gaussian_blur_bitexact_kernels) |
Contributor
There was a problem hiding this comment.
param_check_gaussian_blur_bitexact_kernels
Wrong usage.
This is a CHECK for kernels with logging messages.
| if(!(borderType & BORDER_ISOLATED)) | ||
| src.locateROI( wsz, ofs ); | ||
|
|
||
| CALL_HAL(gaussianBlur, cv_hal_gaussianBlur, src.ptr(), src.step, dst.ptr(), dst.step, src.cols, src.rows, sdepth, cn, |
Contributor
There was a problem hiding this comment.
Where was it previously?
Why is not removed from old location?
| if(!(borderType & BORDER_ISOLATED)) | ||
| src.locateROI( wsz, ofs ); | ||
|
|
||
| CALL_HAL(gaussianBlur, cv_hal_gaussianBlur, src.ptr(), src.step, dst.ptr(), dst.step, src.cols, src.rows, sdepth, cn, |
Contributor
There was a problem hiding this comment.
This API is for pre-bitexact implementation.
Bitexact path should has own (new!) HAL API function.
(we don't change semantic existed API, we add new API with new requirements)
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24850
Try to use CPU HAL for the cases, where OpenCL is not applicable as first option.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.