Merged
Conversation
Contributor
|
Thank you for contribution!
Could you please do "git rebase" to avoid unnecessary "merge" commit in PR? |
Contributor
Author
|
@opencv-alalek thank for taking a look!
I tried it, is this correct? |
Contributor
|
Try the following commands: # make sure this branch is active
git checkout fix-dnn-plugin-build-win32
# reset branch to the first commit
git reset --hard a0b28f8b0640614f2aae771ded8b0a11975a4439
# assuming "upstream" is github.com/opencv/opencv
git rebase upstream/4.x
# push, assuming "origin" is your fork
git push -f origin fix-dnn-plugin-build-win32 |
7738fe6 to
a0b28f8
Compare
Contributor
Author
|
@mshabunin thanks for teaching detail of the process. |
opencv-alalek
approved these changes
Apr 12, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This PR is recreated from #25340)
Fixes #24392.
I'm not sure this is the best practice, but looks working well for me with rev.2c5b296
Any helps or advice are welcomed if this patch need to be modified.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.