Add definition "_USE_MATH_DEFINES" for the dnn plugin of Win32 build#25340
Closed
susumu-iino wants to merge 1 commit intoopencv:4.xfrom
susumu-iino:4.x
Closed
Add definition "_USE_MATH_DEFINES" for the dnn plugin of Win32 build#25340susumu-iino wants to merge 1 commit intoopencv:4.xfrom susumu-iino:4.x
susumu-iino wants to merge 1 commit intoopencv:4.xfrom
susumu-iino:4.x
Conversation
Contributor
|
@susumu-iino , please make a branch with different name in your repository and recreate this PR using the new branch. See https://github.com/opencv/opencv/wiki/Branches for details. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24392.
I'm not sure this is the best practice, but looks working well for me with rev.2b1c8aa.
Any helps or advice are welcomed if this patch need to be modified.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.