Skip to content

Add definition "_USE_MATH_DEFINES" for the dnn plugin of Win32 build#25340

Closed
susumu-iino wants to merge 1 commit intoopencv:4.xfrom
susumu-iino:4.x
Closed

Add definition "_USE_MATH_DEFINES" for the dnn plugin of Win32 build#25340
susumu-iino wants to merge 1 commit intoopencv:4.xfrom
susumu-iino:4.x

Conversation

@susumu-iino
Copy link
Copy Markdown
Contributor

@susumu-iino susumu-iino commented Apr 5, 2024

Fixes #24392.
I'm not sure this is the best practice, but looks working well for me with rev.2b1c8aa.
Any helps or advice are welcomed if this patch need to be modified.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@mshabunin
Copy link
Copy Markdown
Contributor

mshabunin commented Apr 7, 2024

@susumu-iino , please make a branch with different name in your repository and recreate this PR using the new branch.

See https://github.com/opencv/opencv/wiki/Branches for details.

@mshabunin mshabunin closed this Apr 7, 2024
@susumu-iino susumu-iino mentioned this pull request Apr 11, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Building DNN_PLUGIN:openvino is broken in Visual Studio 2019 when -DBUILD_opencv_world=ON

3 participants