dnn: remove Caffe importer for 5.0#25323
Closed
WanliZhong wants to merge 14 commits intoopencv:5.xfrom
Closed
Conversation
This was referenced Apr 3, 2024
dkurt
reviewed
Apr 3, 2024
|
|
||
| For usage download models by following links | ||
| For GOTURN: | ||
| goturn.prototxt and goturn.caffemodel: https://github.com/opencv/opencv_extra/tree/c4219d5eb3105ed8e634278fad312a1a8d2c182d/testdata/tracking |
Member
There was a problem hiding this comment.
I think we should keep GOTURN at least in ONNX format
Member
Author
There was a problem hiding this comment.
We can use VIT Track, since converting goturn to onnx model may cost lots traffic.
Contributor
There was a problem hiding this comment.
Why not move all this in opencv_contrib in dnn_legacy?
Member
Author
There was a problem hiding this comment.
The GOTURN model will take 388 MB of traffic for each download if converted to onnx. If the user wants to use the tracking method, we can recommend they use Vit or dasimRPN. I create PR to remove it #25503
dkurt
reviewed
Apr 3, 2024
6 tasks
6 tasks
asmorkalov
pushed a commit
that referenced
this pull request
May 8, 2024
Change opencv_face_detector related tests and samples from caffe to onnx #25463 Part of #25314 This PR aims to change the tests related to opencv_face_detector from caffe framework to onnx. Tests in `test_int8_layer.cpp` and `test_caffe_importer.cpp` will be removed in #25323 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
6 tasks
Contributor
|
Closed for now as we decide to presume Caffe in 5.0, but mark it deprecated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge with extra opencv/opencv_extra#1166
Merge with contribute ...
TODO:
Disable Tests for Unsupported ONNX Models in Caffe removal #25314
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.