[BugFix] dnn (ONNX): Foce dropping constant inputs in parseClip if they are shared#25319
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Apr 3, 2024
Merged
[BugFix] dnn (ONNX): Foce dropping constant inputs in parseClip if they are shared#25319asmorkalov merged 2 commits intoopencv:4.xfrom
parseClip if they are shared#25319asmorkalov merged 2 commits intoopencv:4.xfrom
Conversation
Member
Author
|
Should we add Gold-YOLO in the integrated YOLO API? @Abdurrahheem |
4 tasks
dkurt
reviewed
Apr 3, 2024
dkurt
approved these changes
Apr 3, 2024
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
[BugFix] dnn (ONNX): Foce dropping constant inputs in parseClip if they are shared opencv#25319 Resolves opencv#25278 Merge with opencv/opencv_extra#1165 In Gold-YOLO ,`Div` has a constant input `B=6` which is then parsed into a `Const` layer in the ONNX importer, but `Clip` also has the shared constant input `max=6` which is already a `Const` layer and then connected to `Elementwise` layer. This should not happen because in the `forward()` of `Elementwise` layer, the legacy code goes through and apply activation to each input. More details on opencv#25278 (comment). ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #25278
Merge with opencv/opencv_extra#1165
In Gold-YOLO ,
Divhas a constant inputB=6which is then parsed into aConstlayer in the ONNX importer, butClipalso has the shared constant inputmax=6which is already aConstlayer and then connected toElementwiselayer. This should not happen because in theforward()ofElementwiselayer, the legacy code goes through and apply activation to each input. More details on #25278 (comment).Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.