Merged
Conversation
Abdurrahheem
approved these changes
Feb 26, 2024
Contributor
Abdurrahheem
left a comment
There was a problem hiding this comment.
👍🏻 expect that some tests are failing
Comment on lines
+1283
to
+1288
| else { | ||
| output = Transpose( | ||
| output, | ||
| outputDims, | ||
| outputPermutation); | ||
| } |
Contributor
There was a problem hiding this comment.
Is this really a needed change?
Contributor
Author
There was a problem hiding this comment.
Contributor
Author
Which one? |
dkurt
approved these changes
Feb 27, 2024
Contributor
Note related to Einusm: PR:4.x / Android-SDK / BuildAndTestSDK |
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
Fix issue opencv#25077 opencv#25100 Fixes opencv#25077 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25077
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.