Skip to content

Added and tested yolov8x model#25095

Merged
asmorkalov merged 2 commits intoopencv:4.xfrom
cabelo:yolov8x
Feb 27, 2024
Merged

Added and tested yolov8x model#25095
asmorkalov merged 2 commits intoopencv:4.xfrom
cabelo:yolov8x

Conversation

@cabelo
Copy link
Copy Markdown
Contributor

@cabelo cabelo commented Feb 26, 2024

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Below is evidence of the test:
opencv

@asmorkalov asmorkalov self-requested a review February 26, 2024 06:14
@asmorkalov asmorkalov changed the title - Added and tested yolov8x model. Added and tested yolov8x model Feb 26, 2024
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, but pre-processing parameters are not obvious for users. I propose to add them to models.yml too.

@asmorkalov asmorkalov added this to the 4.10.0 milestone Feb 26, 2024
@asmorkalov asmorkalov self-assigned this Feb 26, 2024
@cabelo
Copy link
Copy Markdown
Contributor Author

cabelo commented Feb 26, 2024

Works for me, but pre-processing parameters are not obvious for users. I propose to add them to models.yml too.

Thanks done!

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 0b3232a into opencv:4.x Feb 27, 2024
@asmorkalov asmorkalov mentioned this pull request Feb 28, 2024
klatism pushed a commit to klatism/opencv that referenced this pull request May 17, 2024
Added and tested yolov8x model opencv#25095

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [X] I agree to contribute to the project under Apache 2 License.
- [X] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [X] The PR is proposed to the proper branch
- [X] There is a reference to the original bug report and related work
- [X] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [X] The feature is well documented and sample code can be built with the project CMake

Below is evidence of the test:
![opencv](https://github.com/opencv/opencv/assets/675645/40e81951-a8fd-410b-9dfc-c08254f99bdc)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants