Fixes #25056 : Optimising postProcess(const std::vector<Mat>& output_blobs)#25091
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Feb 27, 2024
Merged
Fixes #25056 : Optimising postProcess(const std::vector<Mat>& output_blobs)#25091asmorkalov merged 2 commits intoopencv:4.xfrom
asmorkalov merged 2 commits intoopencv:4.xfrom
Conversation
Optimising postProcess(const std::vector<Mat>& output_blobs)
dkurt
reviewed
Feb 26, 2024
fengyuentau
reviewed
Feb 26, 2024
69991dd to
51c2da0
Compare
dkurt
reviewed
Feb 26, 2024
51c2da0 to
f22b572
Compare
dkurt
approved these changes
Feb 26, 2024
fengyuentau
approved these changes
Feb 27, 2024
Merged
klatism
pushed a commit
to klatism/opencv
that referenced
this pull request
May 17, 2024
Fixes opencv#25056 : Optimising postProcess(const std::vector<Mat>& output_blobs) opencv#25091 Like mentioned in the issue opencv#25056 , I think checking the condition with `scoreThreshold` and then assigning the bounding boxes can optimize the function pretty well. By doing this, we prevent allocating boxes to faces with scores below the threshold. It also reduces the amount of data that needs to be processed during the subsequent NMS step. Builds and passed locally. - [X] I agree to contribute to the project under Apache 2 License. - [X] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [X] The PR is proposed to the proper branch - [X] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake Co-authored-by: Dhanwanth1803 <dhanwanthvarala@gmail,com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like mentioned in the issue #25056 , I think checking the condition with
scoreThresholdand then assigning the bounding boxes can optimize the function pretty well. By doing this, we prevent allocating boxes to faces with scores below the threshold. It also reduces the amount of data that needs to be processed during the subsequent NMS step. Builds and passed locally.Patch to opencv_extra has the same branch name.