Fixing the formula in the documentation of reprojectImageTo3D#25083
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Feb 24, 2024
Merged
Fixing the formula in the documentation of reprojectImageTo3D#25083asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov merged 1 commit intoopencv:4.xfrom
Conversation
Contributor
|
@catree Could you take a look? |
Contributor
|
@mamut-m Thanks for the correction. Mistake is also present in the 3.4 documentation BTW. |
Merged
catree
added a commit
to catree/opencv
that referenced
this pull request
Feb 26, 2024
6 tasks
asmorkalov
added a commit
that referenced
this pull request
Feb 27, 2024
Fix mistake into the reprojectImageTo3D doc. Backport from #25083 PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing the formula in the documentation of reprojectImageTo3D
fixes #25082
The documentation states correctly:
and
But then there is an error in the formula:

This does not make sense since the function wants to calculate$Z$ , it makes no sense to have $z$ on the right side of the equation. It does not have any meaning in a disparity image. The value should be one at that coordinate, to reflect that this is a normalized homogenous coordinate in 3 dimensions.
I fixed it to

which corresponds to the implementation which is (click permalink to get to file):
Vec4d homg_pt = _Q*Vec4d(x, y, d, 1.0);Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Do not apply since this is only a documentation fix:
Patch to opencv_extra has the same branch name.