Skip to content

Fix qrcode bugs#25026

Merged
asmorkalov merged 8 commits intoopencv:4.xfrom
akretz:fix_qrcode_bugs
Feb 16, 2024
Merged

Fix qrcode bugs#25026
asmorkalov merged 8 commits intoopencv:4.xfrom
akretz:fix_qrcode_bugs

Conversation

@akretz
Copy link
Copy Markdown
Contributor

@akretz akretz commented Feb 14, 2024 •
edited by asmorkalov
Loading

This PR fixes #22892, #24011 and #24450 and adds regression tests using the images provided. I've also verified with the benchmark that this doesn't break anything there.

resolves #22892
resolves #24011
resolves #24450
Replaces #23802

Requires extra: opencv/opencv_extra#1148

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added this to the 4.10.0 milestone Feb 15, 2024
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Feb 15, 2024

No regressions in QR code benchmark: opencv/opencv_benchmarks#9

@dkurt
Copy link
Copy Markdown
Member

dkurt commented Feb 15, 2024

There is one optional comment to test data: https://github.com/opencv/opencv_extra/pull/1148/files#r1490488836. If it's possible to test regression on grayscale image, I recommend to use it.

asmorkalov
asmorkalov reviewed Feb 15, 2024
View reviewed changes
@akretz akretz requested a review from asmorkalov February 15, 2024 18:53
asmorkalov
asmorkalov approved these changes Feb 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

AleksandrPanov
AleksandrPanov approved these changes Feb 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov mentioned this pull request Feb 16, 2024
Closed
6 tasks
@asmorkalov asmorkalov merged commit 68f6c81 into opencv:4.x Feb 16, 2024
@jabdoa2
Copy link
Copy Markdown

jabdoa2 commented Feb 16, 2024

Thank you that :-)!

@asmorkalov asmorkalov mentioned this pull request Feb 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@AleksandrPanov AleksandrPanov AleksandrPanov approved these changes

Assignees

No one assigned

Labels

bug category: objdetect

Projects

None yet

Milestone

4.10.0

5 participants

@akretz @asmorkalov @dkurt @jabdoa2 @AleksandrPanov