Merged
Conversation
asmorkalov
reviewed
Feb 13, 2024
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
I propose to report all metrics we have to report table, not only one.
asmorkalov
reviewed
Feb 13, 2024
7eb3a67 to
e03714f
Compare
e3a8437 to
6c458e8
Compare
6c458e8 to
e42faf8
Compare
Contributor
|
Output path works incorrectly. E.g.: |
Contributor
|
I would say, that |
Contributor
|
Need to tune generated diagram, it's not readable. |
Contributor
|
What distance 40 means? |
asmorkalov
reviewed
Feb 15, 2024
python_benchmarks/qr_codes/qr.py
Outdated
| if not os.path.exists(output_dict): | ||
| os.mkdir(output_dict) | ||
| with open(output_dict + "/" + "distances" + '.json', 'w') as fp: | ||
| json.dump(distances, fp, cls=NumpyEncoder) |
Contributor
There was a problem hiding this comment.
please use indent=4 for "human readable" json. Otherwise it's single line document.
6 tasks
Contributor
Author
|
fixed diagram and output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new file log and new formatting
python args:
-p=qrcodes\detection -a=0.3 --metric=intersection_over_union -alg=opencv_aruco