Added screen rotation support to JavaCamera2View amd NativeCameraView. Fixed JavaCamera2View initialization.#24869
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Jan 17, 2024
Conversation
…. Fixed JavaCamera2View initialization
alexlyulkov
commented
Jan 16, 2024
| } | ||
|
|
||
| Log.i(LOGTAG, "Opening camera: " + mCameraID); | ||
| manager.openCamera(mCameraID, mStateCallback, mBackgroundHandler); |
Contributor
Author
There was a problem hiding this comment.
Moved camera starting here, because preview size should be defined before camera start
| mCaptureSession.close(); | ||
| mCaptureSession = null; | ||
| } | ||
| createCameraPreviewSession(); |
Contributor
Author
There was a problem hiding this comment.
There is already a createCameraPreviewSession call in onOpened camera callback.
asmorkalov
reviewed
Jan 17, 2024
modules/java/generator/android-21/java/org/opencv/android/JavaCamera2View.java
Show resolved
Hide resolved
Contributor
|
@alexlyulkov I do not see preview with Pixel8 in Tutorial 4. Just black screen with text status in corner. |
Contributor
|
Tutorial1-Camera-Preview works with all back-ends JavaCameraView, Java2CameraView and NativeCameraView with rotation. Please ignore the previous comment on Tutorial4. The sample does not work without the patch. It should be fixed separately. |
asmorkalov
reviewed
Jan 17, 2024
Comment on lines
+129
to
+131
| android.hardware.Camera.CameraInfo info = new android.hardware.Camera.CameraInfo(); | ||
| android.hardware.Camera.getCameraInfo(localCameraIndex, info); | ||
| int frameRotation = getFrameRotation( |
Contributor
There was a problem hiding this comment.
Looks like you can re-use CameraInfo from cameras iteration when camera is selected.
modules/java/generator/android/java/org/opencv/android/JavaCameraView.java
Show resolved
Hide resolved
modules/java/generator/android-24/java/org/opencv/android/NativeCameraView.java
Show resolved
Hide resolved
Merged
JStech
pushed a commit
to JStech/opencv
that referenced
this pull request
Jan 28, 2024
…ew-rotate Added screen rotation support to JavaCamera2View amd NativeCameraView. Fixed JavaCamera2View initialization. opencv#24869 Added automatic image rotation to JavaCamera2View and NativeCameraView so the video preview was matched with screen orientation. Fixed double preview initialization bug in JavaCamera2View. Added proper cameraID parsing to NativeCameraView similar to JavaCameraView ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added automatic image rotation to JavaCamera2View and NativeCameraView so the video preview was matched with screen orientation.
Fixed double preview initialization bug in JavaCamera2View.
Added proper cameraID parsing to NativeCameraView similar to JavaCameraView
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.