core: try to solve warnings caused by Apple's new LAPACK interface#24804
Merged
asmorkalov merged 8 commits intoopencv:4.xfrom May 21, 2024
Merged
core: try to solve warnings caused by Apple's new LAPACK interface#24804asmorkalov merged 8 commits intoopencv:4.xfrom
asmorkalov merged 8 commits intoopencv:4.xfrom
Conversation
Contributor
|
See https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_DEPLOYMENT_TARGET.html for the first item. Looks like it's what you need. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
asmorkalov
reviewed
Apr 17, 2024
Member
Author
|
@vpisarev @asmorkalov @opencv-alalek Could you review and merge if no further changes are needed? |
asmorkalov
reviewed
May 6, 2024
asmorkalov
approved these changes
May 6, 2024
Junyan721113
pushed a commit
to plctlab/opencv
that referenced
this pull request
May 22, 2024
core: try to solve warnings caused by Apple's new LAPACK interface opencv#24804 Resolves opencv#24660 Apple's BLAS documentation: https://developer.apple.com/documentation/accelerate/blas?language=objc New interface since macOS >= 13.3, iOS >= 16.4. Todo: - [x] Detect macOS version. - [x] ~Detect iOS versions (major and minor version).~ No calling of Accelerate New LAPACK on iOS. - [x] Solve calling `cblas_cgemm` and `cblas_zgemm`. ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
seanm
reviewed
May 22, 2024
Comment on lines
+115
to
+117
| execute_process(COMMAND sw_vers -productVersion | ||
| OUTPUT_VARIABLE MACOS_VERSION | ||
| OUTPUT_STRIP_TRAILING_WHITESPACE) |
Contributor
There was a problem hiding this comment.
This is a problem... it checks the version of macOS on the machine doing the compiling, it does not check the version of macOS that's actually running the code (at runtime). It's common for a developer to be using a new macOS but wanting his code to still run on an old macOS, and that's why these kinds of checks are inappropriate.
Instead, we must check against the 'deployment target' chosen by the developer, set in CMAKE_OSX_DEPLOYMENT_TARGET.
Could we revert this merge, or correct this quickly?
Member
Author
There was a problem hiding this comment.
Let me take care of this. cc @asmorkalov @opencv-alalek
6 tasks
asmorkalov
pushed a commit
that referenced
this pull request
May 30, 2024
core: deployment compatibility for old mac after Accelerate New LAPACK fix #25625 Attempt to fix #24804 (comment) We may need to explicitly add build option `-DCMAKE_OSX_DEPLOYMENT_TARGET=12.0` or environment variable (`export MACOSX_DEPLOYMENT_TARGET=12.0`) for mac builds (python package most probably) on builders with new macOS (>= 13.3). ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
This was referenced May 31, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #24660
Apple's BLAS documentation: https://developer.apple.com/documentation/accelerate/blas?language=objc
New interface since macOS >= 13.3, iOS >= 16.4.
Todo:
Detect iOS versions (major and minor version).No calling of Accelerate New LAPACK on iOS.cblas_cgemmandcblas_zgemm.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.