Skip to content

Remove deprecated CMake variable#24781

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
FantasqueX:remove-deprecated-cmake-variable-2
Jan 9, 2024
Merged

Remove deprecated CMake variable#24781
asmorkalov merged 1 commit intoopencv:4.xfrom
FantasqueX:remove-deprecated-cmake-variable-2

Conversation

@FantasqueX
Copy link
Copy Markdown
Contributor

@FantasqueX FantasqueX commented Dec 27, 2023

CMake variable CMAKE_COMPILER_IS_CCACHE is marked as deprecated and "# FIXIT Avoid setting of CMAKE_ variables". It is introduced in #11167 which is before the release of 4.0. Since it's deprecated almost six years ago, I think it's OK to remove them.

Related: #24771

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

CMake variable `CMAKE_COMPILER_IS_CCACHE` is marked as deprecated and "# FIXIT Avoid setting of CMAKE_ variables". It is introduced in opencv#11167 which is before the release of 4.0. Since it's deprecated almost six years ago, I think it's OK to remove them.

Related: opencv#24771
@opencv-alalek opencv-alalek added category: build/install cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code) labels Dec 27, 2023
@asmorkalov asmorkalov added this to the 4.10.0 milestone Jan 9, 2024
@asmorkalov asmorkalov merged commit 105eb95 into opencv:4.x Jan 9, 2024
This was referenced Jan 19, 2024
@FantasqueX FantasqueX deleted the remove-deprecated-cmake-variable-2 branch June 28, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: build/install cleanup Code cleanup (e.g, drop legacy C-API, legacy unmaintained code)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants