Remove deprecated CMake variable#24771
Merged
asmorkalov merged 1 commit intoopencv:4.xfrom Dec 26, 2023
Merged
Conversation
Two CMake variable are marked as deprecated and "#TODO next release: remove this". It is introduced in opencv#11167 which is before the release of 4.0. Since it's deprecated almost six years ago, I think it's OK to remove them.
FantasqueX
added a commit
to FantasqueX/opencv
that referenced
this pull request
Dec 27, 2023
CMake variable `CMAKE_COMPILER_IS_CCACHE` is marked as deprecated and "# FIXIT Avoid setting of CMAKE_ variables". It is introduced in opencv#11167 which is before the release of 4.0. Since it's deprecated almost six years ago, I think it's OK to remove them. Related: opencv#24771
6 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CMake variable are marked as deprecated and "#TODO next release: remove this". It is introduced in #11167 which is before the release of 4.0. Since it's deprecated almost six years ago, I think it's OK to remove them.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.