Fix mismatch and simplify code in ChessBoardDetector::findQuadNeighbors#24667
Merged
asmorkalov merged 3 commits intoopencv:4.xfrom Dec 24, 2023
Conversation
AleksandrPanov
approved these changes
Dec 10, 2023
Contributor
AleksandrPanov
left a comment
There was a problem hiding this comment.
PR was tested with OpenCV synthetic benchmark.
There is no accuracy regressions.
👍
Maybe it's better to add this line as a comment?
ediff > 15*edge_len2 <=> edge_len1 - edge_len2 > 15*edge_len2 <=> edge_len1 > 16*edge_len2 <=> 1:4 edges ratio
Contributor
Author
Added comment |
…etector-findQuadNeighbors
Contributor
Author
|
@asmorkalov Can you merge this PR please? |
Contributor
|
The extended testing did not reveal any regressions, so potentially the patch can be integrated. However, maybe it's easier to fix the description rather than change the threshold. @asmorkalov, @AleksandrPanov, I'd leave the decision to you, since you have more experience with chessboard detector in the past years. |
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
…implify-code-in-ChessBoardDetector-findQuadNeighbors Fix mismatch and simplify code in ChessBoardDetector::findQuadNeighbors opencv#24667 ### Pull Request Readiness Checklist Сode doesn't match comment. If we want check `1:4` edges ratio and `edge_len` is squared edge length, then we should check ``` ediff > 15*edge_len ``` with constant `15`, not `32`, because ``` ediff > 15*edge_len2 <=> edge_len1 - edge_len2 > 15*edge_len2 <=> edge_len1 > 16*edge_len2 <=> 1:4 edges ratio ``` But for me it's better and simpler to directly check `edge_len1 > 16*edge_len2` See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
Сode doesn't match comment.
If we want check
1:4edges ratio andedge_lenis squared edge length, then we should checkwith constant
15, not32, becauseBut for me it's better and simpler to directly check
edge_len1 > 16*edge_len2See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.