Skip to content

add support Orbbec Gemini2 and Gemini2 XL camera#24666

Merged
asmorkalov merged 7 commits intoopencv:4.xfrom
zzuliys:4.x
Dec 19, 2023
Merged

add support Orbbec Gemini2 and Gemini2 XL camera#24666
asmorkalov merged 7 commits intoopencv:4.xfrom
zzuliys:4.x

Conversation

@zzuliys
Copy link
Copy Markdown
Contributor

@zzuliys zzuliys commented Dec 8, 2023 •
edited
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 8, 2023 

samples/cpp/videocapture_obsensor.cpp:41: trailing whitespace.
+            
samples/cpp/videocapture_obsensor.cpp:43: trailing whitespace.
+            {

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 8, 2023

@WanliZhong @fengyuentau Could you try it with camera?

@asmorkalov asmorkalov added this to the 4.9.0 milestone Dec 8, 2023
@WanliZhong
Copy link
Copy Markdown
Member

WanliZhong commented Dec 8, 2023

OK, I will test

WanliZhong
WanliZhong reviewed Dec 8, 2023
View reviewed changes
@zzuliys
Copy link
Copy Markdown
Contributor Author

zzuliys commented Dec 8, 2023 

samples/cpp/videocapture_obsensor.cpp:41: trailing whitespace.
+            
samples/cpp/videocapture_obsensor.cpp:43: trailing whitespace.
+            {

Extra spaces have been removed

@zzuliys
Copy link
Copy Markdown
Contributor Author

zzuliys commented Dec 15, 2023

@WanliZhong Add note that some Orbbec cameras do not support Linux kernels version.Please check.

WanliZhong
WanliZhong approved these changes Dec 17, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@WanliZhong WanliZhong left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the comment says: "Astra2, Gemini2, and Gemini2L cameras currently only support Windows and Linux kernel versions 4.15, and higher versions of Linux kernel may have exceptions"

The issue will be fixed after 4.9.0 in a separate PR

asmorkalov
asmorkalov reviewed Dec 18, 2023
View reviewed changes
CMakeLists.txt Outdated
OCV_OPTION(WITH_TIMVX "Include Tim-VX support" OFF
VISIBLE_IF TRUE
VERIFY HAVE_TIMVX)
# attention: Astra2, Gemini2, and Gemini2L cameras currently only support Windows and Linux kernel versions <= 4.15, and higher versions of Linux kernel may have exceptions.
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The statement about kernel version is not clear. Do you mean, that camera requires kernel 4.15 or older?
Please add reference to the camera documentation, ticket or whatever to track support status.

modules/videoio/include/opencv2/videoio.hpp Outdated
CAP_XINE = 2400, //!< XINE engine (Linux)
CAP_UEYE = 2500, //!< uEye Camera API
CAP_OBSENSOR = 2600, //!< For Orbbec 3D-Sensor device/module (Astra+, Femto)
CAP_OBSENSOR = 2600, //!< For Orbbec 3D-Sensor device/module (Astra+, Femto, Astra2, Gemini2, Gemini2L, Gemini2XL, Femto Mega) attention: Astra2, Gemini2, and Gemini2L cameras currently only support Windows and Linux kernel versions 4.15, and higher versions of Linux kernel may have exceptions
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same.

Copy link
Copy Markdown
Contributor Author

@zzuliys zzuliys Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have resolved this issue.

@asmorkalov asmorkalov self-assigned this Dec 19, 2023
asmorkalov
asmorkalov approved these changes Dec 19, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit dfc61fb into opencv:4.x Dec 19, 2023
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
@zzuliys @thewoz
Merge pull request opencv#24666 from zzuliys:4.x
d453b03 
Add support for Orbbec Gemini2 and Gemini2 XL camera opencv#24666

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

@WanliZhong WanliZhong WanliZhong approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: videoio(camera)

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@zzuliys @asmorkalov @WanliZhong