Skip to content

Android Studio tutorials rewritten#24653

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
savuor:doc_android_tutorials
Dec 12, 2023
Merged

Android Studio tutorials rewritten#24653
asmorkalov merged 1 commit intoopencv:4.xfrom
savuor:doc_android_tutorials

Conversation

@savuor
Copy link
Copy Markdown
Contributor

@savuor savuor commented Dec 6, 2023 •
edited
Loading

Android dev tutorials were written a long time ago.
Let's refresh them by using Android Studio instead of Eclipse and plugins.

Changes:

  • All instructions rewritten to work on Android Studio
  • OpenCV4Android tutorial is redundant, removed
  • Hello OpenCV sample is simplified, camera is not used

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

asmorkalov
asmorkalov reviewed Dec 6, 2023
View reviewed changes
@asmorkalov asmorkalov added this to the 4.9.0 milestone Dec 6, 2023
@savuor savuor marked this pull request as ready for review December 11, 2023 03:13
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 11, 2023 

/build/precommit_docs/4.x/opencv/doc/tutorials/introduction/android_binary_package/android_dev_intro.markdown:6: warning: unable to resolve reference to `tutorial_O4A_SDK' for \ref command
/build/precommit_docs/4.x/opencv/doc/tutorials/introduction/android_binary_package/dev_with_OCV_on_Android.markdown:4: warning: unable to resolve reference to `tutorial_O4A_SDK' for \ref command
/build/precommit_docs/4.x/opencv/doc/tutorials/introduction/android_binary_package/dev_with_OCV_on_Android.markdown:118: warning: Found unknown command `\Override'
/build/precommit_docs/4.x/opencv/doc/tutorials/introduction/table_of_content_introduction.markdown:24: warning: unable to resolve reference to `tutorial_O4A_SDK' for \ref command

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 11, 2023 •
edited
Loading

General notes:

  • The last image on the first page is broken, not shown in browser.
  • The second page contains some issues with code blocks. I see "```" in many places, but code is not formated.
  • The first tutorial should relay on OpenCV for Android SDK. Please add reference to wiki for "how to build" instruction.

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 12, 2023 

doc/tutorials/introduction/android_binary_package/android_dev_intro.markdown:200: trailing whitespace.
+savuor@rostislav-laptop:~/Android/Sdk/platform-tools$ ./adb devices 
doc/tutorials/introduction/android_binary_package/android_dev_intro.markdown:204: trailing whitespace.
+savuor@rostislav-laptop:~/Android/Sdk/platform-tools$ 
program finished with exit code 2

@asmorkalov asmorkalov force-pushed the doc_android_tutorials branch from ba8d55e to 9ebb0db Compare December 12, 2023 13:36
@asmorkalov asmorkalov self-assigned this Dec 12, 2023
@asmorkalov
Android tutorials refresh
5498f41 
- Use Android Studio instead of Ecliplse.
- Use new Gradle-based OpenCV for Android SDK.
@asmorkalov asmorkalov force-pushed the doc_android_tutorials branch from 9ebb0db to 5498f41 Compare December 12, 2023 13:54
asmorkalov
asmorkalov approved these changes Dec 12, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 850be1e into opencv:4.x Dec 12, 2023
@savuor savuor deleted the doc_android_tutorials branch December 12, 2023 15:41
@savuor savuor mentioned this pull request Dec 13, 2023
Merged
6 tasks
asmorkalov pushed a commit that referenced this pull request Dec 13, 2023
@savuor
Merge pull request #24692 from savuor:doc_android_tutorial_camera
42ab298 
Android camera tutorial update #24692

This PR extends the OpenCV 4 Android tutorial by a simple camera app based on existing code.
This part was accidentally removed during the #24653 preparation, this PR restores it and aligns it to the latest Android Studio.

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
Merged
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
@savuor @thewoz
Merge pull request opencv#24692 from savuor:doc_android_tutorial_camera
5af609c 
Android camera tutorial update opencv#24692

This PR extends the OpenCV 4 Android tutorial by a simple camera app based on existing code.
This part was accidentally removed during the opencv#24653 preparation, this PR restores it and aligns it to the latest Android Studio.

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: documentation Documentation fix or update platform: android

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

2 participants

@savuor @asmorkalov