Merged
Conversation
Contributor
|
@fengyuentau the main problem in #24606 and #23977 is that only box prediction on CUDA backed are zeros. There rest of the outputs are exactly the same as on CPU when CUDA backend is used on YOLOv8. You mentioned here that you have not checked if the behaviour is fixed by this PR. So, does this PR really solve the issue? |
Member
Author
|
The intention of this PR is to support Sub for CUDA backend. It is a basic operation and needs to be supported. |
4 tasks
dkurt
approved these changes
Dec 6, 2023
Abdurrahheem
approved these changes
Dec 6, 2023
|
按照修改的代码重新cmake试了一下，4.8.0的cpu版本正常，gpu版本框的值还是0,0,0,0。4.7.0版本的opencv，gpu运行的值是正常的。 |
Member
Author
So it means something has changed in 4.8.0 that leads to the error. We still need some time to find out why. |
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
dnn cuda: support Sub opencv#24647 Related opencv#24606 (comment) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related #24606 (comment)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.