Skip to content

Fix path to ONNX Runtime include folder#24601

Merged
asmorkalov merged 5 commits intoopencv:4.xfrom
TolyaTalamanov:at/fix-onnxrt-include-path-in-cmake
Dec 15, 2023
Merged

Fix path to ONNX Runtime include folder#24601
asmorkalov merged 5 commits intoopencv:4.xfrom
TolyaTalamanov:at/fix-onnxrt-include-path-in-cmake

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Nov 27, 2023

Pull Request Readiness Checklist

Looks the install directory layout has been changed for v1.16.3

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@TolyaTalamanov TolyaTalamanov changed the title ONNXRuntime: Fix path to ONNX Runtime include folder Fix path to ONNX Runtime include folder Nov 27, 2023
@smirnov-alexey smirnov-alexey self-requested a review November 27, 2023 16:04
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

@asmorkalov Could you have a look at the jobs please? Not sure where I broke the compatibility:

Creating compatibility report ...
Source compatibility: 99.99%
Total source compatibility problems: 4, warnings: 5
Report: abi_report.html

@asmorkalov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov It's not related to your PR.

Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dmatveev dmatveev modified the milestones: 4.9.0, 4.10.0 Dec 13, 2023
@TolyaTalamanov TolyaTalamanov modified the milestones: 4.10.0, 4.9.0 Dec 15, 2023
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

@asmorkalov Can we merge it for 4.9, please?

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 1017ea4 into opencv:4.x Dec 15, 2023
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
…lude-path-in-cmake

Fix path to ONNX Runtime include folder opencv#24601

### Pull Request Readiness Checklist

Looks the `install` directory layout has been changed for `v1.16.3`

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [ ] I agree to contribute to the project under Apache 2 License.
- [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants