Skip to content

Android sample for VideoWriter#24592

Merged
asmorkalov merged 8 commits intoopencv:4.xfrom
savuor:recorder_android
Dec 13, 2023
Merged

Android sample for VideoWriter#24592
asmorkalov merged 8 commits intoopencv:4.xfrom
savuor:recorder_android

Conversation

@savuor
Copy link
Copy Markdown
Contributor

@savuor savuor commented Nov 24, 2023

This PR:

  • adds an Android sample for video recording with MediaNDK and built-in MJPEG.
  • adds a flag --no_media_ndk for build_sdk.py script to disable MediaNDK linkage.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Dec 11, 2023

I fixed merge conflicts, rebased the branch on top of 4.x and made several UI changes. Remaining steps:

  • Use camera fps instead of hard-coded 30fps.
  • Start from camera preview, but not black screen with button.

@asmorkalov asmorkalov marked this pull request as ready for review December 11, 2023 18:26
Alexander Lyulkov added 2 commits December 12, 2023 23:12
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov merged commit 500fd45 into opencv:4.x Dec 13, 2023
@asmorkalov asmorkalov mentioned this pull request Jan 19, 2024
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
Android sample for VideoWriter opencv#24592

This PR:
* adds an Android sample for video recording with MediaNDK and built-in MJPEG.
* adds a flag `--no_media_ndk` for `build_sdk.py` script to disable MediaNDK linkage.

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants