DON'T MERGE, DNN: disable winograd as default#24587
Closed
zihaomu wants to merge 1 commit intoopencv:4.xfrom
Closed
DON'T MERGE, DNN: disable winograd as default#24587zihaomu wants to merge 1 commit intoopencv:4.xfrom
zihaomu wants to merge 1 commit intoopencv:4.xfrom
Conversation
zihaomu
commented
Nov 24, 2023
| util::getParameter(params, "dilation", "dilation", dilations, true, std::vector<size_t>(kernel.size(), 1)); | ||
| util::getParameter(params, "adj", "adj", adjust_pads, true, std::vector<size_t>(kernel.size(), 0)); | ||
| useWinograd = params.get<bool>("use_winograd", true); | ||
| useWinograd = params.get<bool>("use_winograd", useWinograd); |
Member
Author
There was a problem hiding this comment.
Hi @asmorkalov @vpisarev. Previously, due to this line of code, we actually turned on Winograd by default.
6 tasks
asmorkalov
pushed a commit
that referenced
this pull request
Dec 22, 2023
Try to enable Winograd by default in FP32 mode and disable it by default in FP16 mode #24709 Hopefully, it will resolve regressions since 4.8.1 (see also #24587) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
Try to enable Winograd by default in FP32 mode and disable it by default in FP16 mode opencv#24709 Hopefully, it will resolve regressions since 4.8.1 (see also opencv#24587) ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to disable the Winograd compute branch as default, which will greatly affect dnn running performance.
Test at Apple M2 chip, multi-thread:
m2_perf_test.zip
After turn off the Wingrad, 3x3s1 convolution performance drops a lot (4.x vs patch):
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.