dnn: add openvino, opencl and cuda backends for layer normalization layer#24552
Merged
asmorkalov merged 8 commits intoopencv:4.xfrom Nov 21, 2023
Merged
dnn: add openvino, opencl and cuda backends for layer normalization layer#24552asmorkalov merged 8 commits intoopencv:4.xfrom
asmorkalov merged 8 commits intoopencv:4.xfrom
Conversation
Member
|
Oh, wait a minute, why we need continue development of LayerNorm layer while there is a new InstanceNorm layer #24378? I expected that LayerNorm should be removed completely. |
Member
Author
|
We agreed previously in the meeting that we keep two classes, and they share similar kernels for CPU. |
Member
|
Let's see the final state. As far as I remember the only difference between them is scalar or vector scale/bias values, |
Member
Author
Indexing is also different as well. For Instance Normalization, its indexing is like |
dkurt
reviewed
Nov 17, 2023
dkurt
reviewed
Nov 17, 2023
dkurt
approved these changes
Nov 20, 2023
8ab8f52 to
9f0ce10
Compare
IskXCr
pushed a commit
to Haosonn/opencv
that referenced
this pull request
Dec 20, 2023
dnn: add openvino, opencl and cuda backends for layer normalization layer opencv#24552 Merge after opencv#24544. Todo: - [x] openvino - [x] opencl - [x] cuda ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
dnn: add openvino, opencl and cuda backends for layer normalization layer opencv#24552 Merge after opencv#24544. Todo: - [x] openvino - [x] opencl - [x] cuda ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #24544.
Todo:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.