Replace double atomic in USAC#24499
Merged
asmorkalov merged 7 commits intoopencv:4.xfrom Nov 20, 2023
Merged
Conversation
asmorkalov
reviewed
Nov 7, 2023
Contributor
|
@ivashmak I reworked your solution a bit and replaced divider and int cast with floating point arithmetic. It fixes the original linkage issue, but original code is not thread safe by design. Lines like this contain data raises, even if best_score_all is atomic: |
86cadcb to
a29b203
Compare
Contributor
|
@ivashmak I fixed remaining warnings and PR ready for merge. I'll contribute data race with the next PR. |
asmorkalov
pushed a commit
to asmorkalov/opencv
that referenced
this pull request
Nov 20, 2023
Port of solution for: - opencv#24482 - opencv#24281 Original PR: opencv#24499
6 tasks
asmorkalov
pushed a commit
to asmorkalov/opencv
that referenced
this pull request
Nov 20, 2023
Port of solution for: - opencv#24482 - opencv#24281 Original PR: opencv#24499
IskXCr
pushed a commit
to Haosonn/opencv
that referenced
this pull request
Dec 20, 2023
Replace double atomic in USAC opencv#24499 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake Reference to issue with atomic variable: opencv#24281 Reference to bug with essential matrix: opencv#24482
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
Replace double atomic in USAC opencv#24499 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [x] There is a reference to the original bug report and related work - [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [x] The feature is well documented and sample code can be built with the project CMake Reference to issue with atomic variable: opencv#24281 Reference to bug with essential matrix: opencv#24482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Reference to issue with atomic variable: #24281
Reference to bug with essential matrix: #24482