Skip to content

Fixed CumSum layer inplace flag#24367

Merged
asmorkalov merged 3 commits intoopencv:4.xfrom
alexlyulkov:al/fixed-cumsum-inplace-flag
Oct 18, 2023
Merged

Fixed CumSum layer inplace flag#24367
asmorkalov merged 3 commits intoopencv:4.xfrom
alexlyulkov:al/fixed-cumsum-inplace-flag

Conversation

@alexlyulkov
Copy link
Copy Markdown
Contributor

When exclusive is false:
dst[i] = dst[i-1] + src[i]
When exclusive is true:
dst[i] = dst[i-1] + src[i-1]
So CumSum layer can be inplace only when exclusive flag is false.

@asmorkalov
Copy link
Copy Markdown
Contributor

@alexlyulkov please add some test

1 similar comment
@asmorkalov
Copy link
Copy Markdown
Contributor

@alexlyulkov please add some test

@asmorkalov asmorkalov added the pr: needs test New functionality requires minimal tests set label Oct 11, 2023
@asmorkalov asmorkalov added this to the 4.9.0 milestone Oct 11, 2023
@asmorkalov asmorkalov self-requested a review October 12, 2023 14:46
@alexlyulkov
Copy link
Copy Markdown
Contributor Author

Added a test opencv/opencv_extra#1110

@asmorkalov asmorkalov merged commit 014e848 into opencv:4.x Oct 18, 2023
@asmorkalov asmorkalov mentioned this pull request Nov 3, 2023
IskXCr pushed a commit to Haosonn/opencv that referenced this pull request Dec 20, 2023
…ace-flag

Fixed CumSum layer inplace flag opencv#24367

When exclusive is false:
dst[i] = dst[i-1] + src[i]
When exclusive is true:
dst[i] = dst[i-1] + src[i-1]
So CumSum layer can be inplace only when exclusive flag is false.
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
…ace-flag

Fixed CumSum layer inplace flag opencv#24367

When exclusive is false:
dst[i] = dst[i-1] + src[i]
When exclusive is true:
dst[i] = dst[i-1] + src[i-1]
So CumSum layer can be inplace only when exclusive flag is false.
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
…ace-flag

Fixed CumSum layer inplace flag opencv#24367

When exclusive is false:
dst[i] = dst[i-1] + src[i]
When exclusive is true:
dst[i] = dst[i-1] + src[i-1]
So CumSum layer can be inplace only when exclusive flag is false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: dnn pr: needs test New functionality requires minimal tests set

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants