add Intel® oneAPI DPC++/C++ Compiler (icx)#24286
Merged
asmorkalov merged 4 commits intoopencv:4.xfrom Sep 22, 2023
Merged
Conversation
…n a oneAPI release in the second half of 2023. This commit is intended to add support for the next generation compiler, Intel® oneAPI DPC++/C++ Compiler (icx).
Contributor
|
@ashadrina Thanks a lot for the contribution! I tried the patch manually with Ubuntu 18.04 and ICX 2023.2.0 (l_BaseKit_p_2023.2.0.49397_offline.sh). The patch fixes compiler diagnostics and enables platform specific optimizations like AVX, but breaks linkage. Steps to reproduce: |
Contributor
|
Most probably issue is related to cmake/OpenCVCompilerOptions.cmake:183. |
Contributor
|
@ashadrina I pushed commit to your PR to fix linkage issue and some flags. ICX is LLVM-based compiler. Most of CLANG related options are enabled. |
Contributor
|
I tested core module and it produce a lot of failed tests: Findings:
|
Contributor
Author
|
@asmorkalov thank you! Sorry for being late with the response, I am presently trying to figure out why my PR is working on one machine and failing with pthread issue on another. GCC and cmake versions were my main candidates but it seems that the reason is something else. Yes, ICX is using -fp-model=fast -fma and -ffast-math by default. Does -fno-fast-math and (optionally) -fp-model=precise -no-fma fix the rest of the tests? |
Contributor
|
CMake version: |
Contributor
|
I disabled fast-math by default and it fixed most of failures, but I still observe failures with integer arithmetic: The result looks like over-optimization on compiler side. |
cmake/OpenCVCompilerOptions.cmake
Outdated
| # ICX uses -ffast-math by default. | ||
| if(NOT ENABLE_FAST_MATH) | ||
| add_extra_compiler_option(-fno-fast-math) | ||
| add_extra_compiler_option(-fp-model=precise) |
Contributor
There was a problem hiding this comment.
It makes sense to guard this similar to line 101 (like CV_ICC) and/or 93 (MSVS)
Contributor
There was a problem hiding this comment.
Done. Please take a look.
opencv-alalek
approved these changes
Sep 22, 2023
Merged
hanliutong
pushed a commit
to hanliutong/opencv
that referenced
this pull request
Oct 7, 2023
…port Add Intel® oneAPI DPC++/C++ Compiler (icx) opencv#24286 Intel® C++ Compiler Classic (icc) is deprecated and will be removed in a oneAPI release in the second half of 2023 ([deprecation notice](https://community.intel.com/t5/Intel-oneAPI-IoT-Toolkit/DEPRECATION-NOTICE-Intel-C-Compiler-Classic/m-p/1412267#:~:text=Intel%C2%AE%20C%2B%2B%20Compiler%20Classic%20(icc)%20is%20deprecated%20and%20will,the%20second%20half%20of%202023.)). This commit is intended to add support for the next-generation compiler, Intel® oneAPI DPC++/C++ Compiler (icx) (the documentation for the compiler is available on the [link](https://www.intel.com/content/www/us/en/docs/dpcpp-cpp-compiler/developer-guide-reference/2023-2/overview.html)). ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
…port Add Intel® oneAPI DPC++/C++ Compiler (icx) opencv#24286 Intel® C++ Compiler Classic (icc) is deprecated and will be removed in a oneAPI release in the second half of 2023 ([deprecation notice](https://community.intel.com/t5/Intel-oneAPI-IoT-Toolkit/DEPRECATION-NOTICE-Intel-C-Compiler-Classic/m-p/1412267#:~:text=Intel%C2%AE%20C%2B%2B%20Compiler%20Classic%20(icc)%20is%20deprecated%20and%20will,the%20second%20half%20of%202023.)). This commit is intended to add support for the next-generation compiler, Intel® oneAPI DPC++/C++ Compiler (icx) (the documentation for the compiler is available on the [link](https://www.intel.com/content/www/us/en/docs/dpcpp-cpp-compiler/developer-guide-reference/2023-2/overview.html)). ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
…port Add Intel® oneAPI DPC++/C++ Compiler (icx) opencv#24286 Intel® C++ Compiler Classic (icc) is deprecated and will be removed in a oneAPI release in the second half of 2023 ([deprecation notice](https://community.intel.com/t5/Intel-oneAPI-IoT-Toolkit/DEPRECATION-NOTICE-Intel-C-Compiler-Classic/m-p/1412267#:~:text=Intel%C2%AE%20C%2B%2B%20Compiler%20Classic%20(icc)%20is%20deprecated%20and%20will,the%20second%20half%20of%202023.)). This commit is intended to add support for the next-generation compiler, Intel® oneAPI DPC++/C++ Compiler (icx) (the documentation for the compiler is available on the [link](https://www.intel.com/content/www/us/en/docs/dpcpp-cpp-compiler/developer-guide-reference/2023-2/overview.html)). ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [x] I agree to contribute to the project under Apache 2 License. - [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [x] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intel® C++ Compiler Classic (icc) is deprecated and will be removed in a oneAPI release in the second half of 2023 (deprecation notice). This commit is intended to add support for the next-generation compiler, Intel® oneAPI DPC++/C++ Compiler (icx) (the documentation for the compiler is available on the link).
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.