Skip to content

PReLU with element-wise scales#24056

Merged
asmorkalov merged 6 commits intoopencv:4.xfrom
dkurt:eltwise_prelu
Jul 27, 2023
Merged

PReLU with element-wise scales#24056
asmorkalov merged 6 commits intoopencv:4.xfrom
dkurt:eltwise_prelu

Conversation

@dkurt
Copy link
Copy Markdown
Member

@dkurt dkurt commented Jul 25, 2023

Pull Request Readiness Checklist

resolves #24051

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom

Xbuild_image:Custom=ubuntu-openvino-2021.4.2:20.04
build_image:Custom=ubuntu-openvino-2022.1.0:20.04

test_modules:Custom=dnn,python2,python3,java,gapi,video

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

@dkurt dkurt marked this pull request as ready for review July 26, 2023 09:28
@dkurt dkurt marked this pull request as draft July 26, 2023 09:30
@dkurt dkurt marked this pull request as ready for review July 26, 2023 12:33
@asmorkalov asmorkalov requested a review from zihaomu July 26, 2023 17:04
@asmorkalov asmorkalov added this to the 4.9.0 milestone Jul 26, 2023
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 26, 2023 

[ RUN      ] Test_Caffe_nets.FasterRCNN_vgg16/2, where GetParam() = NGRAPH/OCL_FP16
[ INFO:0@130.032] global net_openvino.cpp:676 switchToOpenVINOBackend DNN: switching to OpenVINO backend... (networkID=450)
[ INFO:0@130.342] global ie_ngraph.cpp:823 initPlugin OpenCV/nGraph: using GPU kernels cache: /build/.cache/openvino_cache_GPU_ubuntu_openvino_2022.1.0__20.04/
[ INFO:0@130.343] global ie_ngraph.cpp:860 initPlugin DNN/IE: Calling LoadNetwork(device=HETERO:GPU,CPU)...
Unmatched prediction: class 2 score 0.964355 box [473.766 x 378.733 from (108.551, 130.3)]
Highest IoU: 0.641764
/build/precommit_custom_linux/4.x/opencv/modules/dnn/test/test_common.impl.hpp:145: Failure
Value of: matched
  Actual: false
Expected: true
model name: VGG16_faster_rcnn_final.caffemodel
Unmatched reference: class 2 score 0.949398 box [501.96 x 252.708 from (99.2454, 210.141)] IoU diff: 0.358236
/build/precommit_custom_linux/4.x/opencv/modules/dnn/test/test_common.impl.hpp:157: Failure
Expected: (refScores[i]) <= (confThreshold), actual: 0.949398 vs 0.8
model name: VGG16_faster_rcnn_final.caffemodel
[ INFO:0@132.404] global ts.cpp:857 testTearDown Memory_usage (OpenCL): 489242624 (base=0  current=0)
[  FAILED  ] Test_Caffe_nets.FasterRCNN_vgg16/2, where GetParam() = NGRAPH/OCL_FP16 (2956 ms)

@dkurt
Copy link
Copy Markdown
Member Author

dkurt commented Jul 26, 2023

@asmorkalov, this error is reproduced on 4.x:

[ RUN      ] Test_Caffe_nets.FasterRCNN_vgg16/2, where GetParam() = NGRAPH/OCL_FP16
Unmatched prediction: class 2 score 0.910156 box [528.531 x 252.169 from (77.7105, 209.179)]
Highest IoU: 0
/home/dkurt/opencv/modules/dnn/test/test_common.impl.hpp:145: Failure
Value of: matched
  Actual: false
Expected: true
model name: VGG16_faster_rcnn_final.caffemodel
Unmatched reference: class 2 score 0.949398 box [501.96 x 252.708 from (99.2454, 210.141)] IoU diff: 1
/home/dkurt/opencv/modules/dnn/test/test_common.impl.hpp:157: Failure
Expected: (refScores[i]) <= (confThreshold), actual: 0.949398 vs 0.8
model name: VGG16_faster_rcnn_final.caffemodel
[  FAILED  ] Test_Caffe_nets.FasterRCNN_vgg16/2, where GetParam() = NGRAPH/OCL_FP16 (13016 ms)

@asmorkalov asmorkalov requested a review from Abdurrahheem July 27, 2023 08:36
asmorkalov
asmorkalov reviewed Jul 27, 2023
View reviewed changes
@Abdurrahheem
Copy link
Copy Markdown
Contributor

Abdurrahheem commented Jul 27, 2023

Look Good to me!

@asmorkalov asmorkalov self-assigned this Jul 27, 2023
@asmorkalov asmorkalov removed the request for review from zihaomu July 27, 2023 13:35
@asmorkalov asmorkalov merged commit 677a28f into opencv:4.x Jul 27, 2023
@dkurt dkurt mentioned this pull request Jul 27, 2023
Merged
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Merged
Abdurrahheem

This comment was marked as off-topic.

Sign in to view

thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
@dkurt @thewoz
Merge pull request opencv#24056 from dkurt:eltwise_prelu
28ecb7d 
PReLU with element-wise scales opencv#24056

### Pull Request Readiness Checklist

resolves opencv#24051

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
@dkurt @thewoz
Merge pull request opencv#24056 from dkurt:eltwise_prelu
7c6cccb 
PReLU with element-wise scales opencv#24056

### Pull Request Readiness Checklist

resolves opencv#24051

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [x] I agree to contribute to the project under Apache 2 License.
- [x] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [x] The PR is proposed to the proper branch
- [x] There is a reference to the original bug report and related work
- [x] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [x] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Abdurrahheem Abdurrahheem Abdurrahheem left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: dnn

Projects

None yet

Milestone

4.9.0

Development

Successfully merging this pull request may close these issues.

Test_TensorFlow_layers.tf2_prelu fails with OpenVINO CPU backend

3 participants

@dkurt @asmorkalov @Abdurrahheem