G-API: Support DirectML Execution Provider for ONNXRT Backend#24045
Merged
asmorkalov merged 11 commits intoopencv:4.xfrom Jul 26, 2023
Merged
G-API: Support DirectML Execution Provider for ONNXRT Backend#24045asmorkalov merged 11 commits intoopencv:4.xfrom
asmorkalov merged 11 commits intoopencv:4.xfrom
Conversation
TolyaTalamanov
commented
Jul 21, 2023
| GAPI_WRAP | ||
| DirectML(const int device_id) : ddesc(device_id) { }; | ||
|
|
||
| using DeviceDesc = cv::util::variant<int>; |
Contributor
Author
There was a problem hiding this comment.
It's going to be extended for string (name)
2ee992c to
9c6478b
Compare
dmatveev
reviewed
Jul 21, 2023
TolyaTalamanov
commented
Jul 24, 2023
Contributor
Author
|
@dmatveev @AsyaPronina Could you have a look, please? |
TolyaTalamanov
commented
Jul 24, 2023
TolyaTalamanov
commented
Jul 24, 2023
dmatveev
reviewed
Jul 25, 2023
dmatveev
approved these changes
Jul 25, 2023
| Constructs OpenVINO parameters based on device type information. | ||
|
|
||
| @param device Target device to use. | ||
| @param dev_type Target device type to use. ("CPU_FP32", "GPU_FP16", etc) |
Contributor
There was a problem hiding this comment.
Here comes the question.. Should we expose it as-is or build the right facade atop of it?
Contributor
Author
There was a problem hiding this comment.
I think there is no right facade so far. Only device_type is used correctly by OV EP
Contributor
Author
There was a problem hiding this comment.
I mean, you're right, there is always right facade exists but I didn't get they way how it can be easier than it's now
Contributor
Author
|
@asmorkalov Could you merge this, please? |
6 tasks
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
…tml-execution-provider G-API: Support DirectML Execution Provider for ONNXRT Backend opencv#24045 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
…tml-execution-provider G-API: Support DirectML Execution Provider for ONNXRT Backend opencv#24045 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.