G-API: Fix async inference for OpenVINO backend#23884
Merged
asmorkalov merged 2 commits intoopencv:4.xfrom Jun 28, 2023
Merged
Conversation
TolyaTalamanov
commented
Jun 28, 2023
| if (this_nh == nullptr) { | ||
| this_nh = nh; | ||
| compiled = const_cast<OVUnit&>(ovm.metadata(this_nh).get<OVUnit>()).compile(); | ||
| m_reqPool.reset(new RequestPool(createInferRequests(compiled.compiled_model, 1))); |
Contributor
Author
|
@asmorkalov Could you have a look, please? 😥 |
Contributor
|
@dmatveev Please take a look. |
asmorkalov
reviewed
Jun 28, 2023
| .compile_model(model, params.device, toOV(params.config)); | ||
| } | ||
| return {compiled_model}; | ||
| return {compiled_model, params.nireq}; |
Contributor
There was a problem hiding this comment.
nireq is not modified in compile or somewhere else and used as pipeline input. Why do you need it here?
Contributor
Author
There was a problem hiding this comment.
Well, it should be available from graph metadata in order to extract this value to create RequestPool.
OVCompiled is the only structure which is accessible from meta.
Contributor
Author
There was a problem hiding this comment.
Oh, got your point, let's just get it from OVUnit, thanks!
asmorkalov
approved these changes
Jun 28, 2023
Contributor
asmorkalov
left a comment
There was a problem hiding this comment.
👍 Tested manually with OpenVINO 2022.1.1.7030.
Merged
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
Jan 4, 2024
…r-ov-backend G-API: Fix async inference for OpenVINO backend opencv#23884 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
thewoz
pushed a commit
to thewoz/opencv
that referenced
this pull request
May 29, 2024
…r-ov-backend G-API: Fix async inference for OpenVINO backend opencv#23884 ### Pull Request Readiness Checklist See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request - [ ] I agree to contribute to the project under Apache 2 License. - [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV - [ ] The PR is proposed to the proper branch - [ ] There is a reference to the original bug report and related work - [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable Patch to opencv_extra has the same branch name. - [ ] The feature is well documented and sample code can be built with the project CMake
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.