Skip to content

Reworked calibrate.py#23863

Merged
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/calibrate_py_rework
Jun 25, 2023
Merged

Reworked calibrate.py#23863
asmorkalov merged 1 commit intoopencv:4.xfrom
asmorkalov:as/calibrate_py_rework

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jun 23, 2023

  • Fixed width and height swap in board size
  • Fixed defaults in command line hint
  • Fixed board visualization for Charuco case
  • Used matchImagePoints method to handle partially detected Charuco boards

Replaces: #23757, #23840

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov
Reworked calibrate.py
85ea247 
- Fixed width and height swap in board size
- Fixed defaults in command line hint
- Fixed board visualization for Charuco case
- Used matchImagePoints method to handle partially detected Charuco boards
@asmorkalov asmorkalov added this to the 4.8.0 milestone Jun 23, 2023
@asmorkalov asmorkalov mentioned this pull request Jun 23, 2023
Closed
6 tasks
opencv-alalek
opencv-alalek approved these changes Jun 24, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@opencv-alalek opencv-alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

/cc @siilats @Zhigal

@asmorkalov asmorkalov merged commit c982be3 into opencv:4.x Jun 25, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@opencv-alalek opencv-alalek opencv-alalek approved these changes

@mshabunin mshabunin Awaiting requested review from mshabunin

Assignees

No one assigned

Labels

category: samples

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

2 participants

@asmorkalov @opencv-alalek