Skip to content

default values aligned, formatting fixes#23840

Closed
Zhigal wants to merge 1 commit intoopencv:4.xfrom
Zhigal:4.x
Closed

default values aligned, formatting fixes#23840
Zhigal wants to merge 1 commit intoopencv:4.xfrom
Zhigal:4.x

Conversation

@Zhigal
Copy link
Copy Markdown

@Zhigal Zhigal commented Jun 21, 2023

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Found some discrapency in the doc and the actual values, also fixed some formatting

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@asmorkalov asmorkalov self-assigned this Jun 23, 2023
@asmorkalov asmorkalov added this to the 4.8.0 milestone Jun 23, 2023
--square_size: 50
--marker_size: 25
--square_size: 10
--marker_size: 2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still wrong default according to

args.setdefault('--marker_size', 5)

below.

@asmorkalov asmorkalov mentioned this pull request Jun 23, 2023
6 tasks
@asmorkalov
Copy link
Copy Markdown
Contributor

Replaced with #23863

@asmorkalov asmorkalov closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants