Skip to content

G-API: Implement InferROI, InferList, InferList2 for OpenVINO backend#23799

Merged
asmorkalov merged 6 commits intoopencv:4.xfrom
TolyaTalamanov:at/ov20-backend-implement-missing-kernels
Jun 20, 2023
Merged

G-API: Implement InferROI, InferList, InferList2 for OpenVINO backend#23799
asmorkalov merged 6 commits intoopencv:4.xfrom
TolyaTalamanov:at/ov20-backend-implement-missing-kernels

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@TolyaTalamanov TolyaTalamanov force-pushed the at/ov20-backend-implement-missing-kernels branch from dc18729 to 7f1396d Compare June 15, 2023 15:15
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ctx->out.post(std::move(output), ctx->eptr);
}
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to unify code between the two?

ppp.cfgScaleMean(input_name);
ppp.cfgPostProcessing();
ppp.finalize();
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else it is a blob? should this case be handled? some checks be made? how preprocessing would work for the compiled blobs?

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested manually with OpenVINO 2022.1.1.7030.

@asmorkalov asmorkalov merged commit 71790e1 into opencv:4.x Jun 20, 2023
@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

👍 Tested manually with OpenVINO 2022.1.1.7030.

Thank you!

@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
…mplement-missing-kernels

G-API: Implement InferROI, InferList, InferList2 for OpenVINO backend opencv#23799

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [ ] I agree to contribute to the project under Apache 2 License.
- [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
…mplement-missing-kernels

G-API: Implement InferROI, InferList, InferList2 for OpenVINO backend opencv#23799

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [ ] I agree to contribute to the project under Apache 2 License.
- [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants