Skip to content

G-API: Align IE Backend with the latest OpenVINO version#23796

Merged
asmorkalov merged 5 commits intoopencv:4.xfrom
TolyaTalamanov:at/align-ie-backend-with-latest-openvino
Jun 20, 2023
Merged

G-API: Align IE Backend with the latest OpenVINO version#23796
asmorkalov merged 5 commits intoopencv:4.xfrom
TolyaTalamanov:at/align-ie-backend-with-latest-openvino

Conversation

@TolyaTalamanov
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov commented Jun 14, 2023 •
edited by opencv-alalek
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom
build_image:Custom=ubuntu-openvino-2021.4.2:20.04
test_modules:Custom=gapi,python2,python3,java
buildworker:Custom=linux-1,linux-4
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@dmatveev dmatveev self-assigned this Jun 14, 2023
@dmatveev dmatveev added this to the 4.8.0 milestone Jun 14, 2023
@TolyaTalamanov TolyaTalamanov force-pushed the at/align-ie-backend-with-latest-openvino branch from f115a49 to 38baf68 Compare June 14, 2023 12:09
dmatveev
dmatveev approved these changes Jun 14, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Padme meme style): "We have both version tested on CI, right? Right?..."

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Jun 14, 2023

(Padme meme style): "We have both version tested on CI, right? Right?..."

none of them?

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Jun 14, 2023

@asmorkalov

Our IE Backend shows these warning during compilation for openvino versions higher than 2023.0
(because we include #<inference_engine.hpp>
Is it fine to leave them or we need to suppress?

warning("The Inference Engine API is deprecated and will be removed in the 2024.0 release. For instructions on transitioning to the new API, please refer to https://docs.openvino.ai/latest/openvino_2_0_transition_guide.html")

warning("The nGraph API is deprecated and will be removed in the 2024.0 release. For instructions on transitioning to the new API, please refer to https://docs.openvino.ai/latest/openvino_2_0_transition_guide.html")

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Jun 14, 2023

@asmorkalov

Our IE Backend shows these warning during compilation for openvino versions higher than 2023.0 (because we include #<inference_engine.hpp> Is it fine to leave them or we need to suppress?

warning("The Inference Engine API is deprecated and will be removed in the 2024.0 release. For instructions on transitioning to the new API, please refer to https://docs.openvino.ai/latest/openvino_2_0_transition_guide.html")

warning("The nGraph API is deprecated and will be removed in the 2024.0 release. For instructions on transitioning to the new API, please refer to https://docs.openvino.ai/latest/openvino_2_0_transition_guide.html")

I'd rather keep showing these warning to encourage community use new OV2.0 backend.

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Jun 14, 2023

(Padme meme style): "We have both version tested on CI, right? Right?..."

none of them?

Well, I've tested with both OpenVINO versions seems to be working...

@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jun 14, 2023

@TolyaTalamanov @dmatveev For now Github actions CI does not provide job with IE. I'll take a look at it after release.
I propose to suppress the warning for now to not bother CI, but file a ticket about the API migration. @opencv-alalek What is your opinion on the warning?

@TolyaTalamanov
Copy link
Copy Markdown
Contributor Author

TolyaTalamanov commented Jun 14, 2023

@TolyaTalamanov @dmatveev For now Github actions CI does not provide job with IE. I'll take a look at it after release. I propose to suppress the warning for now to not bother CI, but file a ticket about the API migration. @opencv-alalek What is your opinion on the warning?

Well, we've already migrated to the new API by presenting separate GOVBackend but we still want to keep the legacy API backend which works fine but for OpenVINO 2023.0 it shows warnings...

@asmorkalov asmorkalov merged commit 0cf45b8 into opencv:4.x Jun 20, 2023
@asmorkalov asmorkalov mentioned this pull request Jul 27, 2023
Merged
thewoz pushed a commit to thewoz/opencv that referenced this pull request Jan 4, 2024
@TolyaTalamanov @thewoz
Merge pull request opencv#23796 from TolyaTalamanov:at/align-ie-backe…
c908576 
…nd-with-latest-openvino

G-API: Align IE Backend with the latest OpenVINO version opencv#23796

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [ ] I agree to contribute to the project under Apache 2 License.
- [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
thewoz pushed a commit to thewoz/opencv that referenced this pull request May 29, 2024
@TolyaTalamanov @thewoz
Merge pull request opencv#23796 from TolyaTalamanov:at/align-ie-backe…
4b45e59 
…nd-with-latest-openvino

G-API: Align IE Backend with the latest OpenVINO version opencv#23796

### Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

- [ ] I agree to contribute to the project under Apache 2 License.
- [ ] To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
- [ ] The PR is proposed to the proper branch
- [ ] There is a reference to the original bug report and related work
- [ ] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
      Patch to opencv_extra has the same branch name.
- [ ] The feature is well documented and sample code can be built with the project CMake
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.8.0

Development

Successfully merging this pull request may close these issues.

3 participants

@TolyaTalamanov @asmorkalov @dmatveev